erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/adl: Delegate low-battery shutdown notification to platform

Browse source 
This commit removes the SoC-specific implementation of the early
low-battery shutdown notification. The generic implementation now
resides within the FSP driver layer, requiring only platform-specific
customization.

Platforms can now implement platform_display_early_shutdown_notification()
when CONFIG(PLATFORM_HAS_EARLY_LOW_BATTERY_INDICATOR) is enabled. This
function utilizes ux_inform_user_of_poweroff_operation() to display a
"low-battery shutdown" message using libgfxinit.

BUG=b:339673254
TEST=Verified low battery boot event logging and controlled shutdown.

Change-Id: If9f68b2b5cc710e00584b451f904e60d724d1e32
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/86453
Reviewed-by: Andy Ebrahiem <ahmet.ebrahiem@9elements.com>
Reviewed-by: Jayvik Desai <jayvik@google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Subrata Banik 2025-02-16 23:05:30 +05:30
commit 3a57364bc4
1 changed files with 7 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/soc/intel/alderlake/romstage/fsp_params.c
View file

@ -415,6 +415,13 @@ static void debug_override_memory_init_params(FSP_M_CONFIG *mupd)
debug_get_pch_cpu_tracehub_modes(&mupd->CpuTraceHubMode, &mupd->PchTraceHubMode);
}
#if CONFIG(PLATFORM_HAS_EARLY_LOW_BATTERY_INDICATOR)
void platform_display_early_shutdown_notification(void *arg)
{
ux_inform_user_of_poweroff_operation("low-battery shutdown");
}
#endif
static void fill_fspm_sign_of_life(FSP_M_CONFIG *m_cfg,
FSPM_ARCH_UPD *arch_upd)
{
@ -429,28 +436,6 @@ static void fill_fspm_sign_of_life(FSP_M_CONFIG *m_cfg,
* user with an on-screen text message.
*/
if (!arch_upd->NvsBufferPtr) {
/*
* Low Battery Check During Firmware Update (Chrome OS specific):
* - If `PLATFORM_HAS_EARLY_LOW_BATTERY_INDICATOR` is enabled AND the
* system is in firmware update mode (If valid MRC cache data is not found,
* it means that the system needs to perform), it checks if the battery level is
* critically low.
* - This is because memory training, which can take a significant amount of
* time, might cause an abrupt shutdown due to low battery, interrupting the
* firmware update process and potentially leaving the system in an unstable
* state.
* - To prevent this, if the battery is critically low, the system is powered
* off to allow it to charge. This ensures that the firmware update process
* can complete without interruption.
* - Since a functional GFX mode display may not be ready at this stage, VGA
* mode is used to display a text message informing the user about the
* shutdown.
*/
if (CONFIG(PLATFORM_HAS_EARLY_LOW_BATTERY_INDICATOR) &&
platform_is_low_battery_shutdown_needed()) {
ux_inform_user_of_poweroff_operation("low-battery shutdown");
do_low_battery_poweroff();
}
esol_required = true;
name = "memory training";
elog_add_event_byte(ELOG_TYPE_FW_EARLY_SOL, ELOG_FW_EARLY_SOL_MRC);