From 36f0b1257009e6acd314d319226afdc2fe7f234c Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Fri, 16 Jan 2026 17:32:22 -0600 Subject: [PATCH] util/chromeos/crosfirmware.sh: Exit if shellball extraction fails Test if shellball extraction fails, and if it does, show the output of the command and then exit, as nothing more can be done. Change-Id: I0cd7416c988d11e019bfd0b4cd52af8811e6d1e2 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/90787 Tested-by: build bot (Jenkins) Reviewed-by: Sean Rhodes --- util/chromeos/crosfirmware.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/util/chromeos/crosfirmware.sh b/util/chromeos/crosfirmware.sh index 999b7c201f..3be613de19 100755 --- a/util/chromeos/crosfirmware.sh +++ b/util/chromeos/crosfirmware.sh @@ -103,7 +103,11 @@ extract_coreboot() { echo "Extracting coreboot image" if ! sh $_shellball --unpack $_unpacked >/dev/null 2>&1; then - sh $_shellball --sb_extract $_unpacked >/dev/null 2>&1 + if ! sh $_shellball --sb_extract $_unpacked >$_unpacked/sb_extract.log 2>&1; then + echo "Failed to extract shellball image" + cat $_unpacked/sb_extract.log + exit 1 + fi fi if [ -d $_unpacked/models/ ]; then