From 36a4d922396eccfb0748b44524517c7516056e75 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Mon, 23 Mar 2026 12:04:24 +0100 Subject: [PATCH] util/amdfwtool: Fix APOB_NV quirk Fixes commit "util/amdfwtool: Move APOB_NV quirk to amdfwtool.c". Allow the AMD_BIOS_NV_ST and AMD_BIOS_APOB_NV to end at 16MiB. Fixes a build failure when the region is last in the FMAP. Change-Id: Icfa5b74e98223ff5864299d4e9a2d23606935b80 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/91820 Reviewed-by: Maximilian Brune Tested-by: build bot (Jenkins) --- util/amdfwtool/amdfwtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 4e0901cb7d..fa6382c553 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -1484,7 +1484,7 @@ static void integrate_bios_firmwares(context *ctx, * using an MMIO address is then not as simply as adding * the SPI_ROM_BASE offset anymore. */ - if (fw_table[i].src + fw_table[i].size >= 16*MiB) { + if (fw_table[i].src + fw_table[i].size > 16*MiB) { fprintf(stderr, "APOB_NV location too high (0x%lx + 0x%lx)\n", fw_table[i].src, fw_table[i].size);