From 3639648f8153c3dba99103716151fe5d576115a3 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Fri, 12 Sep 2025 10:00:04 +0000 Subject: [PATCH] mb/google/fatcat/var/felino: Set GPP_A15 and GPP_B23 as not used GPP_B23 and GPP_A15 GPIOs in Felino design being used for MEM straping selection but Felino supports only one mem id (index 0) hence, these GPIO reads were never needed in felino code. The GPP_A15 and GPP_B23 pins on the Fatcat mainboard variant Felino are no longer used. Update the GPIO table to reflect this and explicitly set the pins to not connected (NC) as per schematics dated 08/30. TEST=Able to build and boot google/felino. Change-Id: I9d8ed19aab612f7104227544c24c37d19024cfb0 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/89155 Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- src/mainboard/google/fatcat/variants/felino/gpio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mainboard/google/fatcat/variants/felino/gpio.c b/src/mainboard/google/fatcat/variants/felino/gpio.c index 8b05f1dfc8..3a82f97155 100644 --- a/src/mainboard/google/fatcat/variants/felino/gpio.c +++ b/src/mainboard/google/fatcat/variants/felino/gpio.c @@ -40,8 +40,8 @@ static const struct pad_config gpio_table[] = { PAD_CFG_GPI_SCI_LOW(GPP_A12, NONE, DEEP, LEVEL), /* GPP_A13: Not used */ PAD_NC(GPP_A13, NONE), - /* GPP_A15: HW_ID1 */ - PAD_CFG_GPI(GPP_A15, NONE, PLTRST), + /* GPP_A15: Not used */ + PAD_NC(GPP_A15, NONE), /* GPP_A16: BT_RF_KILL_N */ PAD_CFG_GPO(GPP_A16, 1, DEEP), /* GPP_A17: PCH_WLAN_OFF_N */ @@ -93,8 +93,8 @@ static const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_B21, 0, DEEP), /* GPP_B22: Not used */ PAD_NC(GPP_B22, NONE), - /* GPP_B23: HW_ID0 */ - PAD_CFG_GPI(GPP_B23, NONE, PLTRST), + /* GPP_B23: Not used */ + PAD_NC(GPP_B23, NONE), /* GPP_B24: ESPI_ALERT0_N */ PAD_CFG_NF_IOSSTATE(GPP_B24, UP_20K, DEEP, NF1, IGNORE), /* GPP_B25: Not used */