From 358403335ff05d286f01212c59338e34df0fb05c Mon Sep 17 00:00:00 2001 From: Carl-Daniel Hailfinger Date: Fri, 22 Aug 2008 10:56:36 +0000 Subject: [PATCH] smbus_delay() performs its own inb(0x80). We can use the generic udelay() instead which does the same, and achieve better abstraction. Signed-off-by: Carl-Daniel Hailfinger Acked-by: Ronald G. Minnich git-svn-id: svn://coreboot.org/repository/coreboot-v3@799 f3766cd6-281f-0410-b1cd-43a5c92072e9 --- southbridge/amd/cs5536/smbus_initram.c | 2 +- southbridge/nvidia/mcp55/mcp55_smbus.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/southbridge/amd/cs5536/smbus_initram.c b/southbridge/amd/cs5536/smbus_initram.c index e462c14b30..1ba2d72038 100644 --- a/southbridge/amd/cs5536/smbus_initram.c +++ b/southbridge/amd/cs5536/smbus_initram.c @@ -69,7 +69,7 @@ static void smbus_init(void) */ static void smbus_delay(void) { - /* inb(0x80); */ + /* udelay(1); */ } /** diff --git a/southbridge/nvidia/mcp55/mcp55_smbus.h b/southbridge/nvidia/mcp55/mcp55_smbus.h index 714e44f51f..fa83bb0f96 100644 --- a/southbridge/nvidia/mcp55/mcp55_smbus.h +++ b/southbridge/nvidia/mcp55/mcp55_smbus.h @@ -39,8 +39,7 @@ static inline void smbus_delay(void) { - /* let's hope this is not optimized out */ - (void) inb(0x80); + udelay(1); } int do_smbus_recv_byte(u16 smbus_io_base, u8 device);