erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

x86: use proper types for interrupt callbacks

Browse source 
The mainboard_interrupt_handlers() argument for the function
pointer was using void * as the type. This does not allow the compiler
to catch type differences for the arguments. Thus, some code has been
committed which violates the new interrupt callbacks not taking any
arguments. Make sure the compiler provides a type checking benefit.

Change-Id: I268ec8e16929080955751ef518d65b91895e4308
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/48970
This commit is contained in:
Aaron Durbin 2013-04-23 10:25:34 -05:00 • committed by ChromeBot
commit 33c6af82a4
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/arch/x86/include/arch/interrupt.h
View file

@ -23,9 +23,9 @@
/* setup interrupt handlers for mainboard */
#if CONFIG_PCI_OPTION_ROM_RUN_REALMODE
extern void mainboard_interrupt_handlers(int intXX, void *intXX_func);
extern void mainboard_interrupt_handlers(int intXX, int (*intXX_func)(void));
#elif CONFIG_PCI_OPTION_ROM_RUN_YABEL
#include <device/oprom/yabel/biosemu.h>
#else
static inline void mainboard_interrupt_handlers(int intXX, void *intXX_func) { }
static inline void mainboard_interrupt_handlers(int intXX, int (*intXX_func)(void)) { }
#endif

2
src/device/oprom/realmode/x86.c
View file

@ -118,7 +118,7 @@ static int intXX_unknown_handler(void)
}
/* setup interrupt handlers for mainboard */
void mainboard_interrupt_handlers(int intXX, void *intXX_func)
void mainboard_interrupt_handlers(int intXX, int (*intXX_func)(void))
{
intXX_handler[intXX] = intXX_func;
}