From 32ba0920439559fc3789bfb2894f3a917d1dfcd5 Mon Sep 17 00:00:00 2001 From: Kane Chen Date: Thu, 28 Jul 2016 19:41:15 +0800 Subject: [PATCH] UPSTREAM: google/reef: Add pull up 20K for LPC SERIRQ per hw team's check and info from EDS, this pin needs to be pu 20K. Otherwise SoC may not notice interrupt request from EC over LPC because SERIRQ line is floating. BUG=chrome-os-partner:55586 BRANCH=none TEST=boot ok and Quanta factory verified the keyboard issue is gone Change-Id: I33700d2d7e3377b4dd8244f787a383e1622f9a7d Signed-off-by: Kane Chen Reviewed-on: https://review.coreboot.org/15951 Tested-by: build bot (Jenkins) Reviewed-by: Freddy Paul Reviewed-by: Andrey Petrov Reviewed-on: https://chromium-review.googlesource.com/367368 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Furquan Shaikh --- src/mainboard/google/reef/gpio.h | 2 +- src/soc/intel/apollolake/lpc_lib.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/reef/gpio.h b/src/mainboard/google/reef/gpio.h index 88f5cdc656..1e882150cb 100644 --- a/src/mainboard/google/reef/gpio.h +++ b/src/mainboard/google/reef/gpio.h @@ -77,7 +77,7 @@ static const struct pad_config gpio_table[] = { PAD_CFG_GPI(SMB_DATA, UP_20K, DEEP), /* SMB_DATA */ /* LPC */ - PAD_CFG_NF(LPC_ILB_SERIRQ, NATIVE, DEEP, NF1), /* LPC_SERIRQ */ + PAD_CFG_NF(LPC_ILB_SERIRQ, UP_20K, DEEP, NF1), /* LPC_SERIRQ */ PAD_CFG_NF(LPC_CLKOUT0, NONE, DEEP, NF1), /* LPC_CLKOUT0 */ PAD_CFG_GPI(LPC_CLKOUT1, UP_20K, DEEP), /* LPC_CLKOUT1 -- unused */ PAD_CFG_NF(LPC_AD0, NATIVE, DEEP, NF1), /* LPC_AD0 */ diff --git a/src/soc/intel/apollolake/lpc_lib.c b/src/soc/intel/apollolake/lpc_lib.c index 9428866c8b..7627fea58d 100644 --- a/src/soc/intel/apollolake/lpc_lib.c +++ b/src/soc/intel/apollolake/lpc_lib.c @@ -46,6 +46,7 @@ static const struct lpc_mmio_range { }; static const struct pad_config lpc_gpios[] = { + PAD_CFG_NF(LPC_ILB_SERIRQ, UP_20K, DEEP, NF1), PAD_CFG_NF(LPC_AD0, NATIVE, DEEP, NF1), PAD_CFG_NF(LPC_AD1, NATIVE, DEEP, NF1), PAD_CFG_NF(LPC_AD2, NATIVE, DEEP, NF1),