From 3008b8de53bf04a38e4f64790568c11e7a9e99bf Mon Sep 17 00:00:00 2001 From: Benjamin Doron Date: Fri, 9 May 2025 16:24:39 -0400 Subject: [PATCH] soc/intel/skylake: Show that SMRAM is unconditionally locked Align with Cannon Lake SoCs and make it clear that SMRAM is and should always be locked. This is cleanup, since Skylake's Kconfig selects HAVE_SMI_HANDLER. Change-Id: I136c69ad831d9e16d5034d6e488ee061c9b887f5 Signed-off-by: Benjamin Doron Reviewed-on: https://review.coreboot.org/c/coreboot/+/87618 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/soc/intel/skylake/cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c index 8f294f7c8f..853ad6840e 100644 --- a/src/soc/intel/skylake/cpu.c +++ b/src/soc/intel/skylake/cpu.c @@ -199,8 +199,7 @@ static void post_mp_init(void) global_smi_enable_no_pwrbtn(); /* Lock down the SMRAM space. */ - if (CONFIG(HAVE_SMI_HANDLER)) - smm_lock(); + smm_lock(); if (mp_run_on_all_cpus(vmx_configure, NULL) != CB_SUCCESS) failure = true;