From 2ee78458bec6816821d6fcdc14ece97d02b5a9c9 Mon Sep 17 00:00:00 2001 From: Sowmya Aralguppe Date: Mon, 21 Jul 2025 11:01:26 +0530 Subject: [PATCH] soc/intel/pantherlake: Use CONSUMED_BIOS bit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit After the BIOS reads and processes the crashLog record, it sets the CONSUMED_BIOS bit to indicate that the reading and storing of crashlog record is complete. This is read only bit. When this bit is set , crashlog discovery and data collection are skipped. This bit helps in preventing the same crashLog from being extracted multiple times after a reset. BUG= b:None TEST= The header value during warm boot after crash cpu_cl_disc_tab.header.data dw0=88420003, dw1=0x0 Change-Id: I4b9e6900218f28b6beb71b7667bc1c57f0134a84 Signed-off-by: Sowmya Aralguppe Reviewed-on: https://review.coreboot.org/c/coreboot/+/88499 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal Reviewed-by: Jérémy Compostella Reviewed-by: --- src/soc/intel/pantherlake/crashlog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/intel/pantherlake/crashlog.c b/src/soc/intel/pantherlake/crashlog.c index 0f288efe14..d9a80f46c1 100644 --- a/src/soc/intel/pantherlake/crashlog.c +++ b/src/soc/intel/pantherlake/crashlog.c @@ -17,7 +17,7 @@ #define CRASHLOG_NODES_COUNT 0x1 #define CRASHLOG_PUNIT_STORAGE_OFF_MASK BIT(24) #define CRASHLOG_RE_ARM_STATUS_MASK BIT(25) -#define CRASHLOG_CONSUMED_MASK BIT(31) +#define CRASHLOG_CONSUMED_BIOS_MASK BIT(27) /* Global crashLog info */ static bool m_pmc_crash_log_support; @@ -327,7 +327,7 @@ static bool cpu_cl_gen_discovery_table(void) continue; u32 dw0 = read32p(disc_tab_addr + cur_offset); - if (dw0 & CRASHLOG_CONSUMED_MASK) { + if (dw0 & CRASHLOG_CONSUMED_BIOS_MASK) { printk(BIOS_DEBUG, "cpu crashlog records already consumed." "id: 0x%x dw0: 0x%x\n", i, dw0); break;