From 2d3c3c03f739a3945101df7923897cc1bc06fb45 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 2 Apr 2025 14:03:09 +0100 Subject: [PATCH] mb/starlabs/starbook/*: Tidy GPIO comments for the SMBUS This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: Ia8a2ff8f370fef6249b1edbb08e00a01dedc3a07 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/87113 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c | 11 +++++------ src/mainboard/starlabs/starbook/variants/adl/gpio.c | 11 +++++------ src/mainboard/starlabs/starbook/variants/cml/gpio.c | 8 ++++---- src/mainboard/starlabs/starbook/variants/kbl/gpio.c | 8 ++++---- src/mainboard/starlabs/starbook/variants/mtl/gpio.c | 7 +++---- src/mainboard/starlabs/starbook/variants/rpl/gpio.c | 11 +++++------ src/mainboard/starlabs/starbook/variants/tgl/gpio.c | 8 ++++---- .../starlabs/starfighter/variants/rpl/gpio.c | 11 +++++------ .../starlabs/starlite_adl/variants/mk_v/gpio.c | 11 +++++------ 9 files changed, 40 insertions(+), 46 deletions(-) diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index a7a7fdf132..242124c415 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -70,6 +70,11 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), /* Vendor ID 1 */ PAD_CFG_GPI_SCI(GPP_B2, NONE, PLTRST, EDGE_SINGLE, INVERT), /* Processor Hot */ + /* SMBus */ + PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* DRAM Sleep */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -162,10 +167,6 @@ const struct pad_config gpio_table[] = { /* B25: Not Connected */ PAD_NC(GPP_B25, NONE), - /* C0: SMB Clock */ - PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), - /* C1: SMB Data */ - PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C2: TLS Confidentiality Weak Internal PD 20K Low: Disabled High: Enabled */ @@ -268,8 +269,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E6, 0, DEEP), /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), - /* E8: DRAM Sleep */ - PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 774440b044..3ddf06c7fb 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -74,6 +74,11 @@ const struct pad_config gpio_table[] = { /* TPM */ PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* Interrupt */ + /* SMBus */ + PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* DRAM Sleep */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -165,10 +170,6 @@ const struct pad_config gpio_table[] = { /* B25: Not Connected */ PAD_NC(GPP_B25, NONE), - /* C0: SMB Clock */ - PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), - /* C1: SMB Data */ - PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C2: TLS Confidentiality Weak Internal PD 20K Low: Disabled High: Enabled */ @@ -269,8 +270,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E6, 0, DEEP), /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), - /* E8: DRAM Sleep */ - PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_NC(GPP_E9, NONE), /* E10: PWD Amplifier Input */ diff --git a/src/mainboard/starlabs/starbook/variants/cml/gpio.c b/src/mainboard/starlabs/starbook/variants/cml/gpio.c index e916a9ff42..a844562817 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/cml/gpio.c @@ -63,6 +63,10 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* C10 Gate */ PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* Platform Reset */ + /* SMBus */ + PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ + /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD6: SIO_SLP_A# */ @@ -166,10 +170,6 @@ const struct pad_config gpio_table[] = { /* B23: EC_SLP_S0IX_N */ PAD_NC(GPP_B23, NONE), - /* C0: SMB_CLK */ - PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), - /* C1: SMB_DATA */ - PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C3: Not Connected */ PAD_NC(GPP_C3, NONE), /* C4: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c index 9c195957d3..cdc34ae46f 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c @@ -47,6 +47,10 @@ const struct pad_config gpio_table[] = { /* PCH */ PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* Platform Reset */ + /* SMBus */ + PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ + /* GPD2: Not Connected */ PAD_NC(GPD2, NONE), /* GPD6: Not Connected */ @@ -149,10 +153,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_B22, DN_20K), /* GPP_B23: SML1ALERT#/PCHHOT# */ PAD_NC(GPP_B23, DN_20K), - /*GPP_C0: SMBCLK */ - PAD_CFG_NF(GPP_C0, UP_20K, DEEP, NF1), - /* GPP_C1: SMBDATA */ - PAD_CFG_NF(GPP_C1, UP_20K, DEEP, NF1), /* GPP_C2: SMBALERT# */ PAD_NC(GPP_C2, DN_20K), /* GPP_C3: SML0CLK */ diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index efe8de2325..25c3b0bc53 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -8,10 +8,9 @@ const struct pad_config early_gpio_table[] = { PAD_CFG_NF(GPP_H08, NONE, DEEP, NF1), /* RXD */ PAD_CFG_NF(GPP_H09, NONE, DEEP, NF1), /* TXD */ - /* C00: SMB_CLK */ - PAD_CFG_NF(GPP_C00, NONE, DEEP, NF1), - /* C01: SMB_DATA */ - PAD_CFG_NF(GPP_C01, NONE, DEEP, NF1), + /* SMBus */ + PAD_CFG_NF(GPP_C00, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_C01, NONE, DEEP, NF1), /* Data */ }; const struct pad_config *variant_early_gpio_table(size_t *num) diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 042a24d0be..6682a39cd4 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -76,6 +76,11 @@ const struct pad_config gpio_table[] = { /* TPM */ PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* Interrupt */ + /* SMBus */ + PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* DRAM Sleep */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -168,10 +173,6 @@ const struct pad_config gpio_table[] = { /* B25: Not Connected */ PAD_NC(GPP_B25, NONE), - /* C0: SMB Clock */ - PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), - /* C1: SMB Data */ - PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C2: TLS Confidentiality Weak Internal PD 20K Low: Disabled High: Enabled */ @@ -270,8 +271,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E6, 0, DEEP), /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), - /* E8: DRAM Sleep */ - PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10: PWD Amplifier Input */ diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index fab78cbafa..f4d4db05b5 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -65,6 +65,10 @@ const struct pad_config gpio_table[] = { /* TPM */ PAD_CFG_GPI_APIC_LOW(GPP_C14, NONE, PLTRST), /* Interrupt */ + /* SMBus */ + PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ + /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD6: SIO_SLP_A# */ @@ -155,10 +159,6 @@ const struct pad_config gpio_table[] = { /* B23: CPU_CLKFREQ */ PAD_CFG_GPO(GPP_B23, 0, DEEP), - /* C0: SMBCLK */ - PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), - /* C1: SMBDATA */ - PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C2: SMBALERT_N */ PAD_CFG_GPO(GPP_C2, 0, DEEP), /* C3: SML0_CLK */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index 3f26ff7e19..30c13a6fb3 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -86,6 +86,11 @@ const struct pad_config gpio_table[] = { /* TPM */ PAD_CFG_GPI_APIC_LOW(GPP_D10, NONE, PLTRST), /* Interrupt */ + /* SMBus */ + PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* DRAM Sleep */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -175,10 +180,6 @@ const struct pad_config gpio_table[] = { /* B25: Not Connected */ PAD_NC(GPP_B25, NONE), - /* C0: SMB Clock */ - PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), - /* C1: SMB Data */ - PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C2: TLS Confidentiality Weak Internal PD 20K Low: Disabled High: Enabled */ @@ -271,8 +272,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E6, 0, DEEP), /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), - /* E8: DRAM Sleep */ - PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10: Not Connected */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 58e3d12f08..53ebb43f27 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -71,6 +71,11 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), /* Vendor ID 1 */ PAD_CFG_GPI_SCI(GPP_B2, NONE, PLTRST, EDGE_SINGLE, INVERT), /* Processor Hot */ + /* SMBus */ + PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* DRAM Sleep */ + /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), /* GPD6: Sleep A */ @@ -159,10 +164,6 @@ const struct pad_config gpio_table[] = { /* B25: Not Connected */ PAD_NC(GPP_B25, NONE), - /* C0: SMB Clock */ - PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), - /* C1: SMB Data */ - PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C2: TLS Confidentiality Weak Internal PD 20K Low: Disabled High: Enabled */ @@ -265,8 +266,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E6, 0, DEEP), /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), - /* E8: DRAM Sleep */ - PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_NC(GPP_E9, NONE), /* E10: PWD Amplifier Input */