From 2ce4e09469040effc6bb87a787dcb718440858b6 Mon Sep 17 00:00:00 2001 From: Maximilian Brune Date: Tue, 4 Nov 2025 17:00:21 +0100 Subject: [PATCH] drivers/intel/fsp2_0: Add typedef FSP_UPD_HEADER The FSP structs are usually typedefs and are also used like that across the tree. In order to make this file usable for code inside our tree (specifically AMD) change it to typedefs. Signed-off-by: Maximilian Brune Change-Id: Ie799e0116997ba559b990a9b3a2038fea852d8ba Reviewed-on: https://review.coreboot.org/c/coreboot/+/89901 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/drivers/intel/fsp2_0/include/fsp/upd.h | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/drivers/intel/fsp2_0/include/fsp/upd.h b/src/drivers/intel/fsp2_0/include/fsp/upd.h index 153b174cc3..8c307c5748 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/upd.h +++ b/src/drivers/intel/fsp2_0/include/fsp/upd.h @@ -5,7 +5,8 @@ #include -struct FSP_UPD_HEADER { + +typedef struct { /// /// UPD Region Signature. This signature will be /// "XXXXXX_T" for FSP-T @@ -19,10 +20,10 @@ struct FSP_UPD_HEADER { /// uint8_t Revision; uint8_t Reserved[23]; -} __packed; +} __packed FSP_UPD_HEADER; #if CONFIG(PLATFORM_USES_FSP2_X86_32) -struct FSPM_ARCH_UPD { +typedef struct { /// /// Revision of the structure. For FSP v2.0 value is 1. /// @@ -53,12 +54,12 @@ struct FSPM_ARCH_UPD { /// uint32_t BootMode; uint8_t Reserved1[8]; -} __packed; +} __packed FSPM_ARCH_UPD; #else #error You need to implement this struct for x86_64 FSP #endif -struct FSPS_ARCH_UPD { +typedef struct { /// /// Revision of the structure. For FSP v2.2 value is 1. /// @@ -74,6 +75,6 @@ struct FSPS_ARCH_UPD { /// uint8_t EnableMultiPhaseSiliconInit; uint8_t Reserved2[19]; -} __packed; +} __packed FSPS_ARCH_UPD; #endif /* _FSP2_0_UPD_H_ */