From 2c623c17fbbc1a68531ab6349d99c708f532357f Mon Sep 17 00:00:00 2001 From: Mac Chiang Date: Thu, 27 Mar 2025 17:40:06 +0800 Subject: [PATCH] mb/google/fatcat/var/francka: Add audio_disable_pins disable audio-related pins when the CBI FW_Config is not defined. BUG=b:392007428 TEST=emerge-fatcat coreboot Signed-off-by: Mac Chiang Change-Id: I278106df53635adf2bb9f2eb787231724ad4b372 Reviewed-on: https://review.coreboot.org/c/coreboot/+/87023 Tested-by: build bot (Jenkins) Reviewed-by: Jayvik Desai Reviewed-by: Pranava Y N --- .../fatcat/variants/francka/fw_config.c | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/fatcat/variants/francka/fw_config.c b/src/mainboard/google/fatcat/variants/francka/fw_config.c index b087e27df6..91aa20083c 100644 --- a/src/mainboard/google/fatcat/variants/francka/fw_config.c +++ b/src/mainboard/google/fatcat/variants/francka/fw_config.c @@ -43,6 +43,23 @@ static const struct pad_config hda_enable_pads[] = { PAD_NC(GPP_S05, NONE), }; +static const struct pad_config audio_disable_pads[] = { + PAD_NC(GPP_D09, NONE), + PAD_NC(GPP_D10, NONE), + PAD_NC(GPP_D11, NONE), + PAD_NC(GPP_D12, NONE), + PAD_NC(GPP_D13, NONE), + PAD_NC(GPP_D16, NONE), + PAD_NC(GPP_S00, NONE), + PAD_NC(GPP_S01, NONE), + PAD_NC(GPP_S02, NONE), + PAD_NC(GPP_S03, NONE), + PAD_NC(GPP_S04, NONE), + PAD_NC(GPP_S05, NONE), + PAD_NC(GPP_S06, NONE), + PAD_NC(GPP_S07, NONE), +}; + /* * WWAN: power sequence requires three stages: * step 1: 3.3V power, FCP# (Full Card Power), RST#, and PERST# off @@ -123,8 +140,11 @@ void fw_config_gpio_padbased_override(struct pad_config *padbased_table) return; } - if (fw_config_probe(FW_CONFIG(AUDIO, AUDIO_ALC256M_CG_HDA))) + if (fw_config_probe(FW_CONFIG(AUDIO, AUDIO_ALC256M_CG_HDA))) { GPIO_PADBASED_OVERRIDE(padbased_table, hda_enable_pads); + } else { + GPIO_PADBASED_OVERRIDE(padbased_table, audio_disable_pads); + } if (fw_config_probe(FW_CONFIG(WWAN, WWAN_PRESENT))) { GPIO_PADBASED_OVERRIDE(padbased_table, wwan_pwr_seq3_pads);