erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/ptl: Add ACPI IOST support

Browse source 
Add and enable IOST feature to support Intel's IO Self-Testing Software
(IOST), which is an OS tool for performing electrical margining analysis
on USB4 Host and Device Routers, DP2.1 displays, memory, UFS, and PCIe
Gen4+ devices. This change includes the IOST ACPI device in the SoC's
southbridge ASL and implements the SoC-specific soc_fill_p2sb_ssdt
function used by the common P2SB code to generate ACPI code for enabling
IOST in the DSDT. Additionally, the CBFS option "iost_enable" is
required to enable IOST. Command to add this option to the image:
cbfstool <coreboot_image> add-int -r COREBOOT -i 1 -n option/iost_enable
Note that this cbfstool command is an example, for its syntax format
could be changed in the future versions.

BUG=none
TEST=Build coreboot and add the CBFS option flag to the built image.
Boot to OS and verify IOST can access P2SB registers through the ACPI
interface for electrical margining tests.

Signed-off-by: Cliff Huang <cliff.huang@intel.com>
Change-Id: I6929fa3a44646c5385199a8b1e3d0b681d36c9cc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/90045
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Alicja Michalska <ahplka19@gmail.com>
Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com>
This commit is contained in:
Cliff Huang 2025-11-14 14:27:00 -08:00 • committed by Matt DeVillier
commit 2c58e525e8
2 changed files with 39 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/soc/intel/pantherlake/acpi/southbridge.asl
View file

@ -57,3 +57,6 @@
#if CONFIG(SOC_INTEL_WILDCATLAKE)
#include <soc/intel/common/block/acpi/acpi/ufs.asl>
#endif
/* P2B access for IOST */
#include <soc/intel/common/acpi/iost.asl>

36
src/soc/intel/pantherlake/chip.c
View file

@ -1,5 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <acpi/acpigen.h>
#include <device/device.h>
#include <device/pci.h>
#include <fsp/api.h>
@ -15,6 +16,7 @@
#include <intelblocks/systemagent.h>
#include <intelblocks/tcss.h>
#include <intelblocks/xdci.h>
#include <option.h>
#include <soc/intel/common/reset.h>
#include <soc/intel/common/vbt.h>
#include <soc/iomap.h>
@ -221,6 +223,40 @@ static void cpu_fill_ssdt(const struct device *dev)
generate_cpu_entries(dev);
}
/*
* This implements SoC-specific function used in common P2SB code to generate
* additional P2SB-related ACPI code.
*/
void soc_fill_p2sb_ssdt(const struct device *dev)
{
/*
* Enable IOST for debug via P2SB at OS level. The associated IOST ASL file
* (i.e., src/soc/intel/common/acpi/iost.asl) is included in the SoC's
* southbridge.asl. The CBFS option "iost_enable" is used to expose this
* IOST interface to the OS.
* Use cbfstool command to add this option to the image.
*/
if (!get_uint_option("iost_enable", 0))
return;
printk(BIOS_INFO, "IOST is enabled\n");
/*
* The following generates:
* Scope (\_SB.PCI0.IOST)
* {
* If (CondRefOf (IOSE))
* {
* IOSE = 0x0F
* }
* }
*/
acpigen_write_scope("\\_SB.PCI0.IOST");
acpigen_write_if_cond_ref_of("IOSE");
acpigen_write_store_int_to_namestr(0xf, "IOSE");
acpigen_write_if_end();
acpigen_write_scope_end();
}
static void cpu_set_north_irqs(struct device *dev)
{
irq_program_non_pch();