From 2b7115b13991d88081b74b9aec38007ecdcaad57 Mon Sep 17 00:00:00 2001 From: Keith Hui Date: Sat, 5 Apr 2025 21:09:38 -0400 Subject: [PATCH] mb/hp/snb_ivb_desktops: Add gfx_uma_size options up to 512MB This board is missing option values for 256MB and up. Make complete by referencing asus/p8x7x-series and Intel IVB datasheet vol.2, document #326765. Intel datasheet lists an additional 1GB option for Ivy Bridge CPUs, but since nb/intel/sandybridge/northbridge.c has been found to not handle this setting properly when doing memory calculations, a fix is needed there before it can be included. It was not an option for Sandy Bridge anyway. BUG=https://ticket.coreboot.org/issues/581 Change-Id: Id89290a673b0e5dbc72c11c097aeb70d410adeab Signed-off-by: Keith Hui Reviewed-on: https://review.coreboot.org/c/coreboot/+/87192 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier Reviewed-by: Angel Pons Reviewed-by: Paul Menzel --- src/mainboard/hp/snb_ivb_desktops/cmos.layout | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/mainboard/hp/snb_ivb_desktops/cmos.layout b/src/mainboard/hp/snb_ivb_desktops/cmos.layout index 1fc83b1a55..ac486e553c 100644 --- a/src/mainboard/hp/snb_ivb_desktops/cmos.layout +++ b/src/mainboard/hp/snb_ivb_desktops/cmos.layout @@ -23,7 +23,7 @@ entries 421 1 e 9 sata_mode # coreboot config options: northbridge -432 3 e 11 gfx_uma_size +432 4 e 11 gfx_uma_size 448 128 r 0 vbnv @@ -67,6 +67,15 @@ enumerations 11 4 160M 11 5 192M 11 6 224M +11 7 256M +11 8 288M +11 9 320M +11 10 352M +11 11 384M +11 12 416M +11 13 448M +11 14 480M +11 15 512M # ----------------------------------------------------------------- checksums