From 2ad6b19037966a626485d3bc9a7c6c16d3d4f0c9 Mon Sep 17 00:00:00 2001 From: Hope Wang Date: Wed, 25 Dec 2024 21:26:15 +0800 Subject: [PATCH] soc/mediatek/mt8196: Fix MT6363 buck5 enablement The MT6363 buck5 API's mask and shift settings are incorrect, preventing the buck from being disabled. Resolve the issue by correcting these two values. BUG=b:365445188 TEST=build pass, check buck5 is power off after calling the mt6363_enable_buck5 API. Change-Id: I0af1e0582ae8fc1e219f3cce536aed9985108be5 Signed-off-by: Hope Wang Reviewed-on: https://review.coreboot.org/c/coreboot/+/85838 Reviewed-by: Yu-Ping Wu Tested-by: build bot (Jenkins) Reviewed-by: Yidi Lin --- src/soc/mediatek/common/mt6363.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/mediatek/common/mt6363.c b/src/soc/mediatek/common/mt6363.c index 691282b6bf..20ef9f05ac 100644 --- a/src/soc/mediatek/common/mt6363.c +++ b/src/soc/mediatek/common/mt6363.c @@ -211,7 +211,7 @@ void mt6363_enable_vtref18(bool enable) void mt6363_enable_buck5(bool enable) { - mt6363_write_field(PMIC_VBUCK5_OP_EN_2, enable, 0x7, 0); + mt6363_write_field(PMIC_VBUCK5_OP_EN_2, enable, 0x1, 7); } void mt6363_enable_vcn15(bool enable)