From 2ac0a7feeb532ca4f137ce305bbb83edb91c3126 Mon Sep 17 00:00:00 2001 From: Keith Hui Date: Thu, 28 Nov 2024 14:47:40 -0500 Subject: [PATCH] mb/asus/p8x7x-series: Blink power LED during suspend Extends commit 57946ad8174a ("mb/asus/p8z77-m[_pro]: Blink power LED during suspend") to the entire family. Also, we don't need the 0x for Arg0; it can't go larger than 5. Applied this patch and CB:82556 while developing a port for P8Z77-V LE PLUS variant (which uses GPIO8 for power LED). Its power LED does blink during suspend. Change-Id: Ie30e5ef79a87a3dca6875b0a6e07ae99d0d79e6e Signed-off-by: Keith Hui Reviewed-on: https://review.coreboot.org/c/coreboot/+/82557 Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- src/mainboard/asus/p8x7x-series/acpi/platform.asl | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/mainboard/asus/p8x7x-series/acpi/platform.asl b/src/mainboard/asus/p8x7x-series/acpi/platform.asl index b16ced504c..b5c3fc333a 100644 --- a/src/mainboard/asus/p8x7x-series/acpi/platform.asl +++ b/src/mainboard/asus/p8x7x-series/acpi/platform.asl @@ -1,20 +1,21 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#if CONFIG(POWER_LED_USES_GPIO8) +#define BLINK_POWER_LED GB08 +#else +#define BLINK_POWER_LED GB27 +#endif Method(_PTS, 1) { -#if (CONFIG(BOARD_ASUS_P8Z77_M) || CONFIG(BOARD_ASUS_P8Z77_M_PRO)) /* blink power LED if not turning off */ - If (Arg0 != 0x05) + If (Arg0 != 5) { - GB27 = 1 + BLINK_POWER_LED = 1 } -#endif } Method(_WAK, 1) { -#if (CONFIG(BOARD_ASUS_P8Z77_M) || CONFIG(BOARD_ASUS_P8Z77_M_PRO)) - GB27 = 0 -#endif + BLINK_POWER_LED = 0 Return(Package(){0, 0}) }