erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

arm: Remove some pointless CFLAGS

Browse source 
This patch removes the -ffixed-r8 CFLAG from the coreboot and libpayload
Makefiles. This seems to be a relic from U-Boot, which uses that
register to keep it's global data structure pointer. There's no reason
for us to throw away a perfectly fine register on this already pretty
constrained architecture.

Also removed a config.h inclusion from the Makefile because that should
really be done inside the C files.

BUG=None
TEST=Nyan still boots.

Change-Id: Ia176c0f323c1be07cddf88fa5488788786a27cdf
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/177110
Reviewed-by: Gabe Black <gabeblack@chromium.org>
This commit is contained in:
Julius Werner 2013-11-12 14:46:07 -08:00 • committed by chrome-internal-fetch
commit 2a81112abd
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
payloads/libpayload/arch/arm/Makefile.inc
View file

@ -27,7 +27,7 @@
## SUCH DAMAGE.
##
CFLAGS += -ffixed-r8 -mfloat-abi=hard -marm -mabi=aapcs-linux
CFLAGS += -mfloat-abi=hard -marm -mabi=aapcs-linux
head.o-y += head.S
libc-y += main.c sysinfo.c

4
src/arch/arm/Makefile.inc
View file

@ -82,7 +82,7 @@ ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/mainboard.c
################################################################################
# Common recipes for all stages
CFLAGS += -ffixed-r8 -mno-unaligned-access
CFLAGS += -mno-unaligned-access
$(objcbfs)/%.bin: $(objcbfs)/%.elf
@printf " OBJCOPY $(subst $(obj)/,,$(@))\n"
@ -162,7 +162,7 @@ $(objcbfs)/bootblock.debug: $(src)/arch/arm/bootblock.ld $(obj)/ldoptions $$(boo
ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y)
$(LD) -m armelf_linux_eabi -static -o $@ -L$(obj) $< -T $(src)/arch/arm/bootblock.ld
else
$(CC) $(CFLAGS) -nostartfiles -include $(obj)/config.h -static -o $@ -L$(obj) -T $(src)/arch/arm/bootblock.ld -Wl,--start-group $(bootblock-objs) -Wl,--end-group
$(CC) $(CFLAGS) -nostartfiles -static -o $@ -L$(obj) -T $(src)/arch/arm/bootblock.ld -Wl,--start-group $(bootblock-objs) -Wl,--end-group
endif
################################################################################