From 2a7638480492164274c12ddd7235d6529a8e2012 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Wed, 2 Apr 2025 17:48:48 +0530 Subject: [PATCH] soc/intel/pantherlake: Directly assign HDA SDI enable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The double negation (`!!`) was unnecessarily used when assigning the `pch_hda_sdi_enable` type boolean from the SOC config to the FSP M config. This commit removes the redundant `!!` operator, directly assigning the boolean value of `config->pch_hda_sdi_enable[i]` to `m_cfg->PchHdaSdiEnable[i]`. TEST=Able to build and boot google/fatcat. Change-Id: I9233116ca2bfaeac2f685d464a1cb261f067db6a Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/87109 Reviewed-by: Wonkyu Kim Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal Reviewed-by: Jérémy Compostella --- src/soc/intel/pantherlake/romstage/fsp_params.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/pantherlake/romstage/fsp_params.c b/src/soc/intel/pantherlake/romstage/fsp_params.c index b5fc93bc66..521d2f2f09 100644 --- a/src/soc/intel/pantherlake/romstage/fsp_params.c +++ b/src/soc/intel/pantherlake/romstage/fsp_params.c @@ -162,7 +162,7 @@ static void fill_fspm_audio_params(FSP_M_CONFIG *m_cfg, m_cfg->PchHdaIDispCodecDisconnect = !config->pch_hda_idisp_codec_enable; for (int i = 0; i < MAX_HD_AUDIO_SDI_LINKS; i++) - m_cfg->PchHdaSdiEnable[i] = !!config->pch_hda_sdi_enable[i]; + m_cfg->PchHdaSdiEnable[i] = config->pch_hda_sdi_enable[i]; /* * All the PchHdaAudioLink{Hda|Dmic|Ssp|Sndw}Enable UPDs are used by FSP