From 292fcec3312814d37c9b61a9da508d1305a4d2f1 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Sat, 31 Jan 2026 18:24:20 -0600 Subject: [PATCH] util/superiotool/nuvoton: Drop global CR 0x2d for NCT6791D Per the NCT6791D datasheet, global configuration register 0x2d is reserved, so exclude it from the dump like other reserved registers (0x12, 0x15-0x19, 0x23, etc). This was discovered when comparing datasheets for the -91D and -96D; 0x2d is a strapped register for the -96D, but reserved for the -91D. Change-Id: I7d0372c4592f5532480acc5220ee11d9800d2277 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/91097 Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) Reviewed-by: Alicja Michalska --- util/superiotool/nuvoton.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/superiotool/nuvoton.c b/util/superiotool/nuvoton.c index 5f249e7463..90c7a93f7d 100644 --- a/util/superiotool/nuvoton.c +++ b/util/superiotool/nuvoton.c @@ -688,8 +688,8 @@ static const struct superio_registers reg_table[] = { {EOT}}}, {0xc803, "NCT6791D", { {NOLDN, NULL, - {0x07,0x10,0x11,0x13,0x14,0x1a,0x1b,0x1c,0x1d,0x20,0x21,0x22,0x24,0x25,0x26,0x27,0x28,0x2a,0x2b,0x2c,0x2d,0x2f,EOT}, - {0x00,0xff,0xff,0x00,0x00,0x30,0x70,0x10,0x00,0xc8,0x03,0xff,0x04,0x00,MISC,0x00,0x00,0xc0,0x00,0x01,0x00,MISC,EOT}}, + {0x07,0x10,0x11,0x13,0x14,0x1a,0x1b,0x1c,0x1d,0x20,0x21,0x22,0x24,0x25,0x26,0x27,0x28,0x2a,0x2b,0x2c,0x2f,EOT}, + {0x00,0xff,0xff,0x00,0x00,0x30,0x70,0x10,0x00,0xc8,0x03,0xff,0x04,0x00,MISC,0x00,0x00,0xc0,0x00,0x01,MISC,EOT}}, {0x01, "Parallel Port", {0x30,0x60,0x61,0x70,0x74,0xf0,EOT}, {0x01,0x03,0x78,0x07,0x04,0x3f,EOT}},