From 275beb93db804c9d2ef05e2eb599537d20ef9409 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Tue, 1 Apr 2025 19:14:20 +0530 Subject: [PATCH] mb/google/fatcat: Conditionally check for barrel charger The barrel charger check in `baseboard_devtree_update` was unconditional, increasing boot time on platforms without it. This commit conditions the check on `CONFIG(BOARD_GOOGLE_MODEL_FATCAT)`, making it specific to the fatcat board. This avoids unnecessary delay on platforms like francka and felino. BUG=b:328770565 TEST=Boot time reduced by 56ms. Change-Id: Id7a26b634a1a310f714fbf4b4a2accd75665bc28 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/87064 Reviewed-by: Kapil Porwal Reviewed-by: Pranava Y N Tested-by: build bot (Jenkins) Reviewed-by: Jayvik Desai --- .../google/fatcat/variants/baseboard/fatcat/ramstage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c b/src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c index 030b587579..21f8ccda98 100644 --- a/src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c +++ b/src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c @@ -53,7 +53,7 @@ const struct cpu_tdp_power_limits power_optimized_limits[] = { void baseboard_devtree_update(void) { /* Don't optimize the power limit if booting with barrel attached */ - if (google_chromeec_is_barrel_charger_present()) + if (CONFIG(BOARD_GOOGLE_MODEL_FATCAT) && google_chromeec_is_barrel_charger_present()) return; if (!google_chromeec_is_battery_present())