erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/starlabs/starbook/adl_n: Tidy GPIO comments for eSPI

Browse source 
This is a non-functional change, and only makes the GPIOs easier to read.

Change-Id: I8cf7342e6442d283c5ba4b7ee545aa8ac524e365
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87071
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Sean Rhodes 2025-04-01 21:12:07 +01:00
commit 26484b0b63
1 changed files with 9 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/mainboard/starlabs/starbook/variants/adl_n/gpio.c
View file

@ -25,6 +25,15 @@ const struct pad_config gpio_table[] = {
PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */
PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */
/* eSPI */
// PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A0, UP_20K, DEEP, NF1), /* eSPI IO 0 */
// PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A1, UP_20K, DEEP, NF1), /* eSPI IO 1 */
// PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A2, UP_20K, DEEP, NF1), /* eSPI IO 2 */
// PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A3, UP_20K, DEEP, NF1), /* eSPI IO 3 */
// PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A4, UP_20K, DEEP, NF1), /* eSPI CS 0 */
// PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A9, UP_20K, DEEP, NF1), /* eSPI Clk */
// PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A10, NONE, DEEP, NF1), /* eSPI Reset */
PAD_NC(GPD2, NONE),
PAD_NC(GPD6, NONE),
/* GPD7: Power Adapter Disable */
@ -33,11 +42,6 @@ const struct pad_config gpio_table[] = {
PAD_NC(GPD10, NONE),
PAD_NC(GPD11, NONE),
/* A0: ESPI IO 0 */
/* A1: ESPI IO 1 */
/* A2: ESPI IO 2 */
/* A3: ESPI IO 3 */
/* A4: ESPI CS 0 */
/* A5: Not Connected */
PAD_NC(GPP_A5, NONE),
/* A6: Not Connected */
@ -46,8 +50,6 @@ const struct pad_config gpio_table[] = {
PAD_NC(GPP_A7, NONE),
/* A8: Not Connected */
PAD_NC(GPP_A8, NONE),
/* A9: ESPI Clock */
/* A10: ESPI Reset */
/* A11: Not Connected */
PAD_NC(GPP_A11, NONE),
/* A12: Not Connected */