From 257375eb2442690df4d9ae604df70adea1f52029 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Wed, 5 Mar 2025 09:50:53 +0100 Subject: [PATCH] device/pci_rom: Update debug message Do not assume that a VBIOS has been run when loaded below 1MiB. On recent AMD platforms the VBIOS is loaded into the C/D-segment, but it's not run as CONFIG_VGA_ROM_RUN is not set. Since commit 5f5aa79 "device/pci_rom: Move VBIOS checksum fix" the VBIOS has a valid checksum in ati_rom_acpi_fill_vfct(), thus it's not possible to tell if it has been run or ATOMBIOS tables have been modified. Update the debug message to avoid confusion. Change-Id: I63289ecf2c212f3d95e022e8c47dcd0ac610d970 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/86732 Reviewed-by: Felix Held Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/device/pci_rom.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index 0fe94dbb56..229c6fae4a 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -226,11 +226,7 @@ ati_rom_acpi_fill_vfct(const struct device *device, acpi_vfct_t *vfct_struct, return current; } - printk(BIOS_DEBUG, " Copying %sVBIOS image from %p\n", - rom == (struct rom_header *) - (uintptr_t)PCI_VGA_RAM_IMAGE_START ? - "initialized " : "", - rom); + printk(BIOS_DEBUG, " Copying VBIOS image from %p\n", rom); header->DeviceID = device->device; header->VendorID = device->vendor;