From 24778a25decbcfaa2e8e5daf8c9819d388d86927 Mon Sep 17 00:00:00 2001 From: Luca Lai Date: Thu, 5 Jun 2025 13:06:28 +0800 Subject: [PATCH] mb/trulo/var/pujjolo: Fix gtx functions. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add gtx flag in Kconfig and delete the gtx property to fix build error in below coreboot-0.0.1-r5710: /build/nissa/tmp/portage/sys-boot/coreboot-0.0.1-r5710/work/build/pujjolo/mainboard/google/brya/static.c:213:20: error: 'struct drivers_gfx_generic_device_config' has no member named 'type' coreboot-0.0.1-r5710: 213 | .device[0].type = panel, coreboot-0.0.1-r5710: | ^~~~ coreboot-0.0.1-r5710: /build/nissa/tmp/portage/sys-boot/coreboot-0.0.1-r5710/work/build/pujjolo/mainboard/google/brya/static.c:213:27: error: 'panel' undeclared here (not in a function) coreboot-0.0.1-r5710: 213 | .device[0].type = panel, coreboot-0.0.1-r5710: | ^~~~~ BUG=b:395763555 BRANCH=none TEST=Build pujjolo Change-Id: I4e85f3c9acbee66226d8dd195615d9c9dd212709 Signed-off-by: Luca Lai Reviewed-on: https://review.coreboot.org/c/coreboot/+/87956 Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal Reviewed-by: Subrata Banik --- src/mainboard/google/brya/Kconfig | 1 + src/mainboard/google/brya/variants/pujjolo/overridetree.cb | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 06adc7f346..938bbe220e 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -497,6 +497,7 @@ config BOARD_GOOGLE_PUJJOLO select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_INTEL_MIPI_CAMERA select DRIVERS_I2C_SX9324 + select DRIVERS_GFX_GENERIC select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER select HAVE_WWAN_POWER_SEQUENCE select SOC_INTEL_COMMON_BLOCK_HDA_VERB diff --git a/src/mainboard/google/brya/variants/pujjolo/overridetree.cb b/src/mainboard/google/brya/variants/pujjolo/overridetree.cb index 7588a8bfb5..5a42d3fcef 100644 --- a/src/mainboard/google/brya/variants/pujjolo/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjolo/overridetree.cb @@ -413,8 +413,6 @@ chip soc/intel/alderlake register "device_count" = "4" # DDIA for eDP register "device[0].name" = ""LCD0"" - # Internal panel on the first port of the graphics chip - register "device[0].type" = "panel" # DDIB for HDMI # If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB register "device[1].name" = ""DD01"" @@ -515,7 +513,6 @@ chip soc/intel/alderlake register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_C(RIGHT, LEFT, ACPI_PLD_GROUP(2, 1))" device ref usb2_port2 on end - end chip drivers/usb/acpi register "desc" = ""USB2 Type-A Port A1 (DB)""