From 2389bb0b57a2795ca7385fc99a40c8af4a972d36 Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Fri, 3 Mar 2017 14:41:33 +0100 Subject: [PATCH] UPSTREAM: nb/amd/amdht: Use variable for function name One very long line has to be wrapped to be shorter than 80 characters to satisfy the lint scripts. Note, that this gets rid of the brackets (). BUG=none BRANCH=none TEST=none Change-Id: I096cf6151a68e30a9b438d4b5526d72f0faacd94 Signed-off-by: Patrick Georgi Original-Commit-Id: 3329262ecaa2a21a88cad371c4d18e565a7bd542 Original-Change-Id: Ie98eff360ebc5b68ce496edc15eb2d9fddcac868 Original-Signed-off-by: Paul Menzel Original-Reviewed-on: https://review.coreboot.org/18556 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Werner Zeh Original-Reviewed-by: Philippe Mathieu-Daud Reviewed-on: https://chromium-review.googlesource.com/451358 --- src/northbridge/amd/amdht/ht_wrapper.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/northbridge/amd/amdht/ht_wrapper.c b/src/northbridge/amd/amdht/ht_wrapper.c index 8babb47d6d..f4e8337c8d 100644 --- a/src/northbridge/amd/amdht/ht_wrapper.c +++ b/src/northbridge/amd/amdht/ht_wrapper.c @@ -110,7 +110,7 @@ static void AMD_CB_EventNotify (u8 evtClass, u16 event, const u8 *pEventData0) uint8_t log_level; uint8_t dump_event_detail; - printk(BIOS_DEBUG, "AMD_CB_EventNotify(): "); + printk(BIOS_DEBUG, "%s: ", __func__); /* Decode event */ dump_event_detail = 1; @@ -232,7 +232,7 @@ void amd_ht_init(struct sys_info *sysinfo) { if (!sysinfo) { - printk(BIOS_DEBUG, "Skipping amd_ht_init()\n"); + printk(BIOS_DEBUG, "Skipping %s\n", __func__); return; } @@ -256,9 +256,9 @@ void amd_ht_init(struct sys_info *sysinfo) &sysinfo->ht_link_cfg // struct ht_link_config* }; - printk(BIOS_DEBUG, "Enter amd_ht_init()\n"); + printk(BIOS_DEBUG, "Enter %s\n", __func__); amdHtInitialize(&ht_wrapper); - printk(BIOS_DEBUG, "Exit amd_ht_init()\n"); + printk(BIOS_DEBUG, "Exit %s\n", __func__); } /** @@ -268,7 +268,7 @@ void amd_ht_init(struct sys_info *sysinfo) * */ void amd_ht_fixup(struct sys_info *sysinfo) { - printk(BIOS_DEBUG, "amd_ht_fixup()\n"); + printk(BIOS_DEBUG, "%s\n", __func__); if (IS_ENABLED(CONFIG_CPU_AMD_MODEL_10XXX)) { uint8_t rev_gte_d = 0; uint8_t fam15h = 0; @@ -307,7 +307,11 @@ void amd_ht_fixup(struct sys_info *sysinfo) { for (node = 0; node < node_count; node++) { f3xe8 = pci_read_config32(NODE_PCI(node, 3), 0xe8); uint8_t internal_node_number = ((f3xe8 & 0xc0000000) >> 30); - printk(BIOS_DEBUG, "amd_ht_fixup(): node %d (internal node ID %d): disabling defective HT link", node, internal_node_number); + printk(BIOS_DEBUG, + "%s: node %d (internal node " + "ID %d): disabling defective " + "HT link", __func__, node, + internal_node_number); if (internal_node_number == 0) { uint8_t package_link_3_connected = pci_read_config32(NODE_PCI(node, 0), (fam15h)?0x98:0xd8) & 0x1; printk(BIOS_DEBUG, " (L3 connected: %d)\n", package_link_3_connected);