From 224ddb85e3ed0a49de71614a9c3612e822df314e Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 4 Nov 2025 20:56:43 +0000 Subject: [PATCH] ec/starlabs/merlin: Choose a better default for GPE SCI This isn't a function change, it just reduces the number of overrides. Change-Id: I9178028b40c04fe52f4f549365828005cfe5f8be Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/89911 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/ec/starlabs/merlin/Kconfig | 2 +- src/mainboard/starlabs/byte_adl/Kconfig | 3 --- src/mainboard/starlabs/starbook/Kconfig | 1 - src/mainboard/starlabs/starfighter/Kconfig | 3 --- src/mainboard/starlabs/starlite_adl/Kconfig | 3 --- 5 files changed, 1 insertion(+), 11 deletions(-) diff --git a/src/ec/starlabs/merlin/Kconfig b/src/ec/starlabs/merlin/Kconfig index 8599fa903c..c21ac68a0a 100644 --- a/src/ec/starlabs/merlin/Kconfig +++ b/src/ec/starlabs/merlin/Kconfig @@ -49,7 +49,7 @@ config EC_VARIANT_DIR config EC_GPE_SCI hex - default 0x50 + default 0x6e config EC_STARLABS_BATTERY_MODEL string diff --git a/src/mainboard/starlabs/byte_adl/Kconfig b/src/mainboard/starlabs/byte_adl/Kconfig index e0e6de1267..04bdcc8ee2 100644 --- a/src/mainboard/starlabs/byte_adl/Kconfig +++ b/src/mainboard/starlabs/byte_adl/Kconfig @@ -52,9 +52,6 @@ config DEVICETREE config DIMM_SPD_SIZE default 512 -config EC_GPE_SCI - default 0x6e - config EC_STARLABS_ITE_BIN_PATH string default "3rdparty/blobs/mainboard/\$(MAINBOARDDIR)/\$(CONFIG_VARIANT_DIR)/ec.bin" diff --git a/src/mainboard/starlabs/starbook/Kconfig b/src/mainboard/starlabs/starbook/Kconfig index 27761dc507..7a7ac3919e 100644 --- a/src/mainboard/starlabs/starbook/Kconfig +++ b/src/mainboard/starlabs/starbook/Kconfig @@ -132,7 +132,6 @@ config DIMM_SPD_SIZE config EC_GPE_SCI default 0x50 if BOARD_STARLABS_LABTOP_KBL || BOARD_STARLABS_LABTOP_CML - default 0x6e config EC_STARLABS_BATTERY_MODEL default "AEC3987118-2S1P" if BOARD_STARLABS_LABTOP_KBL || BOARD_STARLABS_LABTOP_CML diff --git a/src/mainboard/starlabs/starfighter/Kconfig b/src/mainboard/starlabs/starfighter/Kconfig index a5dbe709c8..cad5ac64a1 100644 --- a/src/mainboard/starlabs/starfighter/Kconfig +++ b/src/mainboard/starlabs/starfighter/Kconfig @@ -59,9 +59,6 @@ config DEVICETREE config DIMM_SPD_SIZE default 512 -config EC_GPE_SCI - default 0x6e - config EC_STARLABS_BATTERY_MODEL default "AEC617573-4S1P" diff --git a/src/mainboard/starlabs/starlite_adl/Kconfig b/src/mainboard/starlabs/starlite_adl/Kconfig index 68e6df8a81..6e66d653b0 100644 --- a/src/mainboard/starlabs/starlite_adl/Kconfig +++ b/src/mainboard/starlabs/starlite_adl/Kconfig @@ -52,9 +52,6 @@ config DEVICETREE config DIMM_SPD_SIZE default 512 -config EC_GPE_SCI - default 0x6e - config EC_STARLABS_BATTERY_MODEL default "AEC3756153-2S1P-N"