From 2171af0f5f67c4e29c043c9e6a8be41b451dabcf Mon Sep 17 00:00:00 2001 From: "Johann C. Rode" Date: Sat, 13 Dec 2025 11:54:29 -0800 Subject: [PATCH] mb/lenovo/sklkbl_x280: Fix build failure This fixes the build failure for commit 0b4d41004 (mb/lenovo/sklkbl: Add Lenovo Thinkpad X280 as a variant) caused by a discrepancy between memory/Makefile.mk and the actual content of spd/ddr4. Change-Id: I92a4446e7bd457a7f09a107a0cb0fe1d7a6e1de4 Signed-off-by: Johann C. Rode Reviewed-on: https://review.coreboot.org/c/coreboot/+/90503 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- .../sklkbl_thinkpad/variants/x280/memory/Makefile.mk | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mainboard/lenovo/sklkbl_thinkpad/variants/x280/memory/Makefile.mk b/src/mainboard/lenovo/sklkbl_thinkpad/variants/x280/memory/Makefile.mk index cba70e22ac..68617d4dfa 100644 --- a/src/mainboard/lenovo/sklkbl_thinkpad/variants/x280/memory/Makefile.mk +++ b/src/mainboard/lenovo/sklkbl_thinkpad/variants/x280/memory/Makefile.mk @@ -4,19 +4,19 @@ # util/spd_tools/bin/part_id_gen TGL ddr4 src/mainboard/lenovo/sklkbl_thinkpad/variants/x280/memory src/mainboard/lenovo/sklkbl_thinkpad/variants/x280/memory/mem_parts_used.txt SPD_SOURCES = -SPD_SOURCES += spd/ddr4/set-0/spd-15.hex # ID = 0(0b0000) Parts = MT40A256M16GE-083E:B +SPD_SOURCES += spd/ddr4/set-0/spd-14.hex # ID = 0(0b0000) Parts = MT40A256M16GE-083E:B SPD_SOURCES += spd/ddr4/set-0/spd-12.hex # ID = 1(0b0001) Parts = MT40A512M16JY-083E:B SPD_SOURCES += spd/ddr4/set-0/spd-12.hex # ID = 2(0b0010) Parts = MT40A512M16JY-083E:B SPD_SOURCES += spd/ddr4/set-0/spd-12.hex # ID = 3(0b0011) Parts = MT40A512M16LY-075:H SPD_SOURCES += spd/ddr4/set-0/spd-12.hex # ID = 4(0b0100) Parts = MT40A512M16LY-075:H SPD_SOURCES += spd/ddr4/set-0/spd-13.hex # ID = 5(0b0101) Parts = MT40A1G16WBU-083E:B -SPD_SOURCES += spd/ddr4/set-0/spd-16.hex # ID = 6(0b0110) Parts = K4A4G165WE-BCRC +SPD_SOURCES += spd/ddr4/set-0/spd-15.hex # ID = 6(0b0110) Parts = K4A4G165WE-BCRC SPD_SOURCES += spd/ddr4/set-0/spd-12.hex # ID = 7(0b0111) Parts = K4A8G165WC-BCRC SPD_SOURCES += spd/ddr4/set-0/spd-12.hex # ID = 8(0b1000) Parts = K4A8G165WC-BCRC -SPD_SOURCES += spd/ddr4/set-0/spd-14.hex # ID = 9(0b1001) Parts = K4AAG165WB-MCRC -SPD_SOURCES += spd/ddr4/set-0/spd-16.hex # ID = 10(0b1010) Parts = H5AN4G6NAFR-UHC +SPD_SOURCES += spd/ddr4/set-0/spd-13.hex # ID = 9(0b1001) Parts = K4AAG165WB-MCRC +SPD_SOURCES += spd/ddr4/set-0/spd-15.hex # ID = 10(0b1010) Parts = H5AN4G6NAFR-UHC SPD_SOURCES += spd/ddr4/set-0/spd-12.hex # ID = 11(0b1011) Parts = H5AN8G6NAFR-UHC SPD_SOURCES += spd/ddr4/set-0/spd-12.hex # ID = 12(0b1100) Parts = H5AN8G6NAFR-UHC -SPD_SOURCES += spd/ddr4/set-0/spd-17.hex # ID = 13(0b1101) Parts = H5ANAG6NAMR-UHC +SPD_SOURCES += spd/ddr4/set-0/spd-16.hex # ID = 13(0b1101) Parts = H5ANAG6NAMR-UHC SPD_SOURCES += spd/ddr4/set-0/spd-12.hex # ID = 14(0b1110) Parts = MT40A512M16LY-075:E SPD_SOURCES += spd/ddr4/set-0/spd-12.hex # ID = 15(0b1111) Parts = MT40A512M16LY-075:E