erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "mb/google/brya/var/xol: Change touchpad I2C interrupt type to GPIO_INT"

Browse source 
This reverts commit aa6865291a.

Reason for revert: We applied this patch for touchpad stuttering issue
for XOl, but the same touchpad problem was reported. So we would revert
this change and apply kernel patch (crrev/c/5808335) to avoid the
touchpad issue.

Change-Id: I78139932e76dbd4128fb325dd70b7dcff3bcc81c
Signed-off-by: Seunghwan Kim <sh_.kim@samsung.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84058
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Seunghwan Kim 2024-08-23 20:13:38 +09:00 • committed by Felix Held
commit 1f4e8ac060
2 changed files with 2 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/mainboard/google/brya/variants/xol/gpio.c
View file

@ -119,13 +119,6 @@ static const struct pad_config gpio_overrides[] = {
PAD_NC(GPP_F12, NONE),
/* F13 : GSXDOUT ==> NC */
PAD_NC(GPP_F13, NONE),
/* F14 : GSXDIN ==> TCHPAD_INT_ODL */
/*
* FIXME: Change back the interrupt type to IRQxAPIC if possible after investigating
* the reason why Xol shows touchpad stuttering issue with IRQxAPIC
* configuration but not GPI_INT.
*/
PAD_CFG_GPI_INT(GPP_F14, NONE, PWROK, LEVEL),
/* F15 : GSXSRESET# ==> PU 100K 3.3V */
PAD_CFG_GPI(GPP_F15, NONE, DEEP),
/* F16 : GSXCLK ==> NC */

7
src/mainboard/google/brya/variants/xol/overridetree.cb
View file

@ -341,11 +341,8 @@ chip soc/intel/alderlake
chip drivers/i2c/hid
register "generic.hid" = ""ZNT0000""
register "generic.desc" = ""Zinitix Touchpad""
# FIXME: Change back the interrupt type to IRQxAPIC if possible
# after investigating the reason why Xol shows touchpad
# stuttering issue with IRQxAPIC configuration but not
# GPI_INT.
register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW_WAKE(GPP_F14)"
register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_F14_IRQ)"
register "generic.wake" = "GPE0_DW2_14"
register "generic.detect" = "1"
register "hid_desc_reg_offset" = "0xE"
device i2c 40 on end