From 1f0d3db4f4257a727f6ccc79822be87df3802360 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Mon, 3 Feb 2025 15:24:40 -0600 Subject: [PATCH] soc/intel/{adl,tgl}: Set PMC ACPI device to hidden/on MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This prevents Windows from displaying the PMC device in Device Manager as an unknown device with no driver available, and brings Alderlake and Tigerlake in line with Meteorlake and Pantherlake. TEST=build/boot Win11 on starlabs/starlite_adl, verify PMC device not shown as unknown device in Device Manager. Change-Id: I4bd62d113455fab7fcb272d85f70e6a185e53b74 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/86256 Tested-by: build bot (Jenkins) Reviewed-by: Jérémy Compostella Reviewed-by: Sean Rhodes --- src/soc/intel/alderlake/pmc.c | 2 +- src/soc/intel/tigerlake/pmc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/intel/alderlake/pmc.c b/src/soc/intel/alderlake/pmc.c index 8930a06251..58c9fa8771 100644 --- a/src/soc/intel/alderlake/pmc.c +++ b/src/soc/intel/alderlake/pmc.c @@ -108,7 +108,7 @@ static void soc_pmc_fill_ssdt(const struct device *dev) acpigen_write_name_string("_HID", PMC_HID); acpigen_write_name_string("_DDN", "Intel(R) Alder Lake IPC Controller"); - acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); + acpigen_write_STA(ACPI_STATUS_DEVICE_HIDDEN_ON); /* * Part of the PCH's reserved 32 MB MMIO range (0xFC800000 - 0xFE7FFFFF). diff --git a/src/soc/intel/tigerlake/pmc.c b/src/soc/intel/tigerlake/pmc.c index 8912cb3c63..8846c94464 100644 --- a/src/soc/intel/tigerlake/pmc.c +++ b/src/soc/intel/tigerlake/pmc.c @@ -107,7 +107,7 @@ static void soc_pmc_fill_ssdt(const struct device *dev) acpigen_write_name_string("_HID", PMC_HID); acpigen_write_name_string("_DDN", "Intel(R) Tiger Lake IPC Controller"); - acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); + acpigen_write_STA(ACPI_STATUS_DEVICE_HIDDEN_ON); /* * Part of the PCH's reserved 32 MB MMIO range (0xFC800000 - 0xFE7FFFFF).