erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

TPM: Reduce buffer size to fix stack overflow

Browse source 
The TPM driver by default allocates a 4K transfer buffer on the stack,
which leads to lots of fun on boards with 2K or 3K stack sizes. On
RK3288 this ends up writing over random memory sections which dependent
on the memlayout of the day might contain timestamp data (no big deal)
or page tables (-> bad time).

This patch fixes the problem by reducing the buffer size to slightly
above 1K, which still seems to work as far as I can tell. There was
already some really odd code that #undef'ed this value and redefined it
with the lower number in one .c file (unfortunately not the one with the
buffer declaration), with no explanation whatsoever... I'm removing that
and just assume the smaller value will be fine for everything.

BRANCH=veyron
BUG=None
TEST=Booted Pinky and Falco.

Change-Id: Idf80f44cbfb9617c56b64a5c88ebedf7fcb4ec71
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/236976
Reviewed-by: David Hendricks <dhendrix@chromium.org>
(cherry picked from commit 3d3288041b6629b7623b9d58816e782e72836b81)
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/237202
This commit is contained in:
Julius Werner 2014-12-19 14:38:51 -08:00 • committed by chrome-internal-fetch
commit 1ec3389514
2 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/drivers/i2c/tpm/tpm.c
View file

@ -45,12 +45,6 @@
#include <device/i2c.h>
#include "tpm.h"
/* max. buffer size supported by our TPM */
#ifdef TPM_BUFSIZE
#undef TPM_BUFSIZE
#endif
#define TPM_BUFSIZE 1260
/* Address of the TPM on the I2C bus */
#define TPM_I2C_ADDR 0x20

4
src/drivers/i2c/tpm/tpm.h
View file

@ -42,8 +42,8 @@ enum tpm_timeout {
TPM_TIMEOUT = 1, /* msecs */
};
/* Size of external transmit buffer (used in tpm_transmit)*/
#define TPM_BUFSIZE 4096
/* Size of external transmit buffer (used for stack buffer in tpm_sendrecv) */
#define TPM_BUFSIZE 1260
/* Index of fields in TPM command buffer */
#define TPM_CMD_SIZE_BYTE 2