vboot: fix CONFIG_RESUME_PATH_SAME_AS_BOOT S3 resume logic
- should not check VBOOT_STARTS_IN_BOOTBLOCK to set context flag - implement vboot_platform_is_resuming on platforms missing it - add ACPI_INTEL_HARDWARE_SLEEP_VALUES to two intel southbridges [ originally https://review.coreboot.org/c/coreboot/+/28750 ] BUG=b:114018226 TEST=compile coreboot Change-Id: I1ef0bcdfd01746198f8140f49698b58065d820b9 Signed-off-by: Joel Kitching <kitching@google.com> Reviewed-on: https://review.coreboot.org/29060 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
This commit is contained in:
parent
c5d0a2ea1f
commit
1d93b88af2
9 changed files with 53 additions and 1 deletions
|
|
@ -14,6 +14,7 @@
|
|||
*/
|
||||
|
||||
#include <stdint.h>
|
||||
#include <arch/acpi.h>
|
||||
#include <arch/io.h>
|
||||
#include <cbmem.h>
|
||||
#include <console/console.h>
|
||||
|
|
@ -23,6 +24,7 @@
|
|||
#include <soc/pci_devs.h>
|
||||
#include <soc/pmc.h>
|
||||
#include <security/vboot/vbnv.h>
|
||||
#include <security/vboot/vboot_common.h>
|
||||
|
||||
#if defined(__SIMPLE_DEVICE__)
|
||||
|
||||
|
|
@ -384,3 +386,11 @@ int vbnv_cmos_failed(void)
|
|||
{
|
||||
return rtc_failure();
|
||||
}
|
||||
|
||||
int vboot_platform_is_resuming(void)
|
||||
{
|
||||
if (!(inw(ACPI_BASE_ADDRESS + PM1_STS) & WAK_STS))
|
||||
return 0;
|
||||
|
||||
return acpi_sleep_from_pm1(inl(ACPI_BASE_ADDRESS + PM1_CNT)) == ACPI_S3;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -14,6 +14,7 @@
|
|||
* GNU General Public License for more details.
|
||||
*/
|
||||
|
||||
#include <arch/acpi.h>
|
||||
#include <arch/io.h>
|
||||
#include <cbmem.h>
|
||||
#include <console/console.h>
|
||||
|
|
@ -24,6 +25,7 @@
|
|||
#include <soc/pm.h>
|
||||
#include <stdint.h>
|
||||
#include <security/vboot/vbnv.h>
|
||||
#include <security/vboot/vboot_common.h>
|
||||
|
||||
#if defined(__SIMPLE_DEVICE__)
|
||||
|
||||
|
|
@ -380,3 +382,11 @@ int vbnv_cmos_failed(void)
|
|||
{
|
||||
return rtc_failure();
|
||||
}
|
||||
|
||||
int vboot_platform_is_resuming(void)
|
||||
{
|
||||
if (!(inw(ACPI_BASE_ADDRESS + PM1_STS) & WAK_STS))
|
||||
return 0;
|
||||
|
||||
return acpi_sleep_from_pm1(inl(ACPI_BASE_ADDRESS + PM1_CNT)) == ACPI_S3;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -18,6 +18,7 @@
|
|||
* and the differences between PCH variants.
|
||||
*/
|
||||
|
||||
#include <arch/acpi.h>
|
||||
#include <arch/io.h>
|
||||
#include <device/device.h>
|
||||
#include <device/pci.h>
|
||||
|
|
@ -29,6 +30,7 @@
|
|||
#include <soc/pm.h>
|
||||
#include <soc/gpio.h>
|
||||
#include <security/vboot/vbnv.h>
|
||||
#include <security/vboot/vboot_common.h>
|
||||
|
||||
/* Print status bits with descriptive names */
|
||||
static void print_status_bits(u32 status, const char *bit_names[])
|
||||
|
|
@ -473,3 +475,11 @@ int vbnv_cmos_failed(void)
|
|||
{
|
||||
return rtc_failure();
|
||||
}
|
||||
|
||||
int vboot_platform_is_resuming(void)
|
||||
{
|
||||
if (!(inw(ACPI_BASE_ADDRESS + PM1_STS) & WAK_STS))
|
||||
return 0;
|
||||
|
||||
return acpi_sleep_from_pm1(inl(ACPI_BASE_ADDRESS + PM1_CNT)) == ACPI_S3;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -39,6 +39,7 @@
|
|||
#include <version.h>
|
||||
#include <pc80/mc146818rtc.h>
|
||||
#include <device/pci_def.h>
|
||||
#include <security/vboot/vboot_common.h>
|
||||
|
||||
/* Return 0, 3, 4 or 5 to indicate the previous sleep state. */
|
||||
uint32_t chipset_prev_sleep_state(uint32_t clear)
|
||||
|
|
@ -271,3 +272,8 @@ uint64_t get_initial_timestamp(void)
|
|||
{
|
||||
return 0;
|
||||
}
|
||||
|
||||
int vboot_platform_is_resuming(void)
|
||||
{
|
||||
return !!romstage_handoff_is_resume();
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue