From 1d02f139d3988e0b9e8ada928992a03cb5d4ef5b Mon Sep 17 00:00:00 2001 From: Jeremy Compostella Date: Thu, 4 Sep 2025 14:46:47 -0700 Subject: [PATCH] mb/google/fatcat: Add wake configuration to cnvi_bluetooth This commit adds a wake configuration to the cnvi_bluetooth device for all the Fatcat board variants. The "wake" setting is now registered to "GPE0_PME_B0" using the common CNVi block. This enhancement ensures that the cnvi_bluetooth device can properly wake the system. TEST=Able to wake up the device from a low power state using a keyboard Bluetooth device. Change-Id: Id0ef732d45b46a3f59456860d9070fffdab05509 Signed-off-by: Jeremy Compostella Reviewed-on: https://review.coreboot.org/c/coreboot/+/89058 Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- .../google/fatcat/variants/fatcat/overridetree.cb | 4 ++++ .../google/fatcat/variants/felino/overridetree.cb | 4 ++++ .../google/fatcat/variants/francka/overridetree.cb | 7 ++++++- .../google/fatcat/variants/kinmen/overridetree.cb | 7 ++++++- src/mainboard/google/fatcat/variants/lapis/overridetree.cb | 4 ++++ .../google/fatcat/variants/moonstone/overridetree.cb | 7 ++++++- 6 files changed, 30 insertions(+), 3 deletions(-) diff --git a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb index 4c75c332ca..f98fb46d53 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb @@ -641,6 +641,10 @@ chip soc/intel/pantherlake device ref cnvi_bluetooth on probe WIFI WIFI_CNVI_6 probe WIFI WIFI_CNVI_7 + chip soc/intel/common/block/cnvi + register "wake" = "GPE0_PME_B0" + device generic 0 on end + end end # NOTE: i2c0 is function 0; hence it needs to be enabled when any of i2c1-5 is enabled. diff --git a/src/mainboard/google/fatcat/variants/felino/overridetree.cb b/src/mainboard/google/fatcat/variants/felino/overridetree.cb index 7d80164942..b4869ead78 100644 --- a/src/mainboard/google/fatcat/variants/felino/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/felino/overridetree.cb @@ -331,6 +331,10 @@ device ref tbt_pcie_rp0 on end device ref cnvi_bluetooth on probe WIFI WIFI_CNVI_6 probe WIFI WIFI_CNVI_7 + chip soc/intel/common/block/cnvi + register "wake" = "GPE0_PME_B0" + device generic 0 on end + end end device ref i2c0 on end diff --git a/src/mainboard/google/fatcat/variants/francka/overridetree.cb b/src/mainboard/google/fatcat/variants/francka/overridetree.cb index 68e3b6635a..4b758ea293 100644 --- a/src/mainboard/google/fatcat/variants/francka/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/francka/overridetree.cb @@ -190,7 +190,12 @@ chip soc/intel/pantherlake end end # CNVi - device ref cnvi_bluetooth on end + device ref cnvi_bluetooth on + chip soc/intel/common/block/cnvi + register "wake" = "GPE0_PME_B0" + device generic 0 on end + end + end # NOTE: i2c0 is function 0; hence it needs to be enabled when any of i2c1-5 is enabled. # TPM device is under i2c1. Therefore, i2c0 needs to be enabled anyways. diff --git a/src/mainboard/google/fatcat/variants/kinmen/overridetree.cb b/src/mainboard/google/fatcat/variants/kinmen/overridetree.cb index e710082746..2a9b91b05a 100644 --- a/src/mainboard/google/fatcat/variants/kinmen/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/kinmen/overridetree.cb @@ -392,7 +392,12 @@ chip soc/intel/pantherlake end end # CNVi - device ref cnvi_bluetooth on end + device ref cnvi_bluetooth on + chip soc/intel/common/block/cnvi + register "wake" = "GPE0_PME_B0" + device generic 0 on end + end + end # NOTE: i2c0 is function 0; hence it needs to be enabled when any of i2c1-5 is enabled. # TPM device is under i2c3. Therefore, i2c0 needs to be enabled anyways. diff --git a/src/mainboard/google/fatcat/variants/lapis/overridetree.cb b/src/mainboard/google/fatcat/variants/lapis/overridetree.cb index f206e272ab..39da99b14c 100644 --- a/src/mainboard/google/fatcat/variants/lapis/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/lapis/overridetree.cb @@ -398,6 +398,10 @@ chip soc/intel/pantherlake device ref cnvi_bluetooth on probe WIFI WIFI_CNVI_7 probe WIFI WIFI_CNVI_7E + chip soc/intel/common/block/cnvi + register "wake" = "GPE0_PME_B0" + device generic 0 on end + end end device ref thc0 on diff --git a/src/mainboard/google/fatcat/variants/moonstone/overridetree.cb b/src/mainboard/google/fatcat/variants/moonstone/overridetree.cb index 535d0a902b..be75530d76 100644 --- a/src/mainboard/google/fatcat/variants/moonstone/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/moonstone/overridetree.cb @@ -299,7 +299,12 @@ chip soc/intel/pantherlake end end # CNVi - device ref cnvi_bluetooth on end + device ref cnvi_bluetooth on + chip soc/intel/common/block/cnvi + register "wake" = "GPE0_PME_B0" + device generic 0 on end + end + end # NOTE: i2c0 is function 0; hence it needs to be enabled when any of i2c1-5 is enabled. # TPM device is under i2c3. Therefore, i2c0 needs to be enabled anyways.