From 1b14664311bf97e31d71ae56af1a6a6e832b0557 Mon Sep 17 00:00:00 2001 From: Kilian Krause Date: Fri, 13 Jun 2025 10:33:20 +0200 Subject: [PATCH] mb/siemens/mc_rpl: Remove unused DPTF settings Since the CPU does not control any fans and the mainboard does not implement a charger, remove all unnecessary DPTF UPDs. DPTF will be used for limitting PL1 and PL2 in the future. Change-Id: I22e1167cb2986f5c56ff6085236792adbb9a19cc Signed-off-by: Kilian Krause Reviewed-on: https://review.coreboot.org/c/coreboot/+/88954 Reviewed-by: Mario Scheithauer Tested-by: build bot (Jenkins) --- src/mainboard/siemens/mc_rpl/devicetree.cb | 72 ---------------------- 1 file changed, 72 deletions(-) diff --git a/src/mainboard/siemens/mc_rpl/devicetree.cb b/src/mainboard/siemens/mc_rpl/devicetree.cb index 1d7eec4a1f..8cacb34b04 100644 --- a/src/mainboard/siemens/mc_rpl/devicetree.cb +++ b/src/mainboard/siemens/mc_rpl/devicetree.cb @@ -20,52 +20,6 @@ chip soc/intel/alderlake device ref igpu on end device ref dtt on chip drivers/intel/dptf - - ## sensor information - register "options.tsr[0].desc" = ""Ambient"" - register "options.tsr[1].desc" = ""Battery"" - register "options.tsr[2].desc" = ""DDR"" - register "options.tsr[3].desc" = ""Skin"" - - ## Active Policy - # TODO: below values are initial reference values only - register "policies.active" = "{ - [0] = { - .target = DPTF_CPU, - .thresholds = { - TEMP_PCT(95, 90), - TEMP_PCT(90, 80), - } - }, - [1] = { - .target = DPTF_TEMP_SENSOR_0, - .thresholds = { - TEMP_PCT(80, 90), - TEMP_PCT(70, 80), - } - } - }" - - ## Passive Policy - # TODO: below values are initial reference values only - register "policies.passive" = "{ - [0] = DPTF_PASSIVE(CPU, CPU, 95, 10000), - [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 85, 50000), - [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_1, 85, 50000), - [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 85, 50000), - [4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 85, 50000), - }" - - ## Critical Policy - # TODO: below values are initial reference values only - register "policies.critical" = "{ - [0] = DPTF_CRITICAL(CPU, 105, SHUTDOWN), - [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 95, SHUTDOWN), - [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 95, SHUTDOWN), - [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 95, SHUTDOWN), - [4] = DPTF_CRITICAL(TEMP_SENSOR_3, 95, SHUTDOWN), - }" - ## Power Limits Control register "controls.power_limits" = "{ .pl1 = { @@ -84,32 +38,6 @@ chip soc/intel/alderlake } }" - ## Charger Performance Control (Control, mA) - register "controls.charger_perf" = "{ - [0] = { 255, 3000 }, - [1] = { 24, 1500 }, - [2] = { 16, 1000 }, - [3] = { 8, 500 } - }" - - ## Fan Performance Control (Percent, Speed, Noise, Power) - register "controls.fan_perf" = "{ - [0] = { 90, 6700, 220, 2200, }, - [1] = { 80, 5800, 180, 1800, }, - [2] = { 70, 5000, 145, 1450, }, - [3] = { 60, 4900, 115, 1150, }, - [4] = { 50, 3838, 90, 900, }, - [5] = { 40, 2904, 55, 550, }, - [6] = { 30, 2337, 30, 300, }, - [7] = { 20, 1608, 15, 150, }, - [8] = { 10, 800, 10, 100, }, - [9] = { 0, 0, 0, 50, } - }" - - ## Fan options - register "options.fan.fine_grained_control" = "true" - register "options.fan.step_size" = "2" - device generic 0 alias dptf_policy on end end end