soc/intel/block/pmc: Only include the PCI driver when it is not hidden

On more recent Intel platforms FSP-S hides the PMC PCI device and the
driver is broken for those devices so don't include it at all.

Change-Id: I784be250698ec1c1e9b3b766cf1bcca55730c021
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47756
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>

src/soc/intel/apollolake/Kconfig

@@ -78,6 +78,7 @@ config CPU_SPECIFIC_OPTIONS
 	select SOC_INTEL_COMMON_BLOCK_PCR
 	select SOC_INTEL_COMMON_BLOCK_P2SB
 	select SOC_INTEL_COMMON_BLOCK_PMC
+	select SOC_INTEL_COMMON_BLOCK_PMC_DISCOVERABLE
 	select SOC_INTEL_COMMON_BLOCK_SRAM
 	select SOC_INTEL_COMMON_BLOCK_RTC
 	select SOC_INTEL_COMMON_BLOCK_SA

src/soc/intel/common/block/pmc/Kconfig

@@ -13,6 +13,12 @@ if SOC_INTEL_COMMON_BLOCK_PMC
 config POWER_STATE_DEFAULT_ON_AFTER_FAILURE
 	default y
 
+config SOC_INTEL_COMMON_BLOCK_PMC_DISCOVERABLE
+	bool
+	help
+	  Select this on platforms where the PMC device is discoverable
+	  when scanning busses.
+
 endif # SOC_INTEL_COMMON_BLOCK_PMC
 
 config PMC_INVALID_READ_AFTER_WRITE

src/soc/intel/common/block/pmc/Makefile.inc

@@ -1,7 +1,7 @@
 ifeq ($(CONFIG_SOC_INTEL_COMMON_BLOCK_PMC),y)
 bootblock-y += pmclib.c
 romstage-y += pmclib.c
-ramstage-y += pmc.c
+ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_PMC_DISCOVERABLE) += pmc.c
 ramstage-y += pmclib.c pmc_ipc.c
 smm-y += pmclib.c
 verstage-y += pmclib.c

src/soc/intel/skylake/Kconfig

@@ -55,6 +55,7 @@ config CPU_SPECIFIC_OPTIONS
 	select SOC_INTEL_COMMON_BLOCK_GPIO_PADCFG_PADTOL
 	select SOC_INTEL_COMMON_BLOCK_GSPI
 	select SOC_INTEL_COMMON_BLOCK_HDA
+	select SOC_INTEL_COMMON_BLOCK_PMC_DISCOVERABLE
 	select SOC_INTEL_COMMON_BLOCK_SA
 	select SOC_INTEL_COMMON_BLOCK_SCS
 	select SOC_INTEL_COMMON_BLOCK_SGX