From 172853a8ceddb90e8305bade0e9c600443cc2cad Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Fri, 28 Feb 2025 14:18:19 +0000 Subject: [PATCH] mb/starlabs/starbook/mtl: Don't configure MUX pins These were incorrectly copied from Alder Lake so remove them as they are not correct nor needed. Change-Id: I70708212c4652ed77c875242340c30edf5b935a1 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/86651 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- .../starlabs/starbook/variants/mtl/Makefile.mk | 1 - .../starlabs/starbook/variants/mtl/ramstage.c | 14 -------------- 2 files changed, 15 deletions(-) delete mode 100644 src/mainboard/starlabs/starbook/variants/mtl/ramstage.c diff --git a/src/mainboard/starlabs/starbook/variants/mtl/Makefile.mk b/src/mainboard/starlabs/starbook/variants/mtl/Makefile.mk index 9abc069b38..2a505c35c7 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/Makefile.mk +++ b/src/mainboard/starlabs/starbook/variants/mtl/Makefile.mk @@ -7,4 +7,3 @@ romstage-y += romstage.c ramstage-y += devtree.c ramstage-y += gpio.c ramstage-y += hda_verb.c -ramstage-y += ramstage.c diff --git a/src/mainboard/starlabs/starbook/variants/mtl/ramstage.c b/src/mainboard/starlabs/starbook/variants/mtl/ramstage.c deleted file mode 100644 index c01c4dd10f..0000000000 --- a/src/mainboard/starlabs/starbook/variants/mtl/ramstage.c +++ /dev/null @@ -1,14 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void mainboard_silicon_init_params(FSP_S_CONFIG *supd) -{ - /* - * FSP defaults to pins that are used for LPC; given that - * coreboot only supports eSPI, set these pins accordingly. - */ - supd->PchSerialIoI2cSdaPinMux[0] = 0x1947c404; // GPP_H4 - supd->PchSerialIoI2cSclPinMux[0] = 0x1947a405; // GPP_H5 -}