From 139a5b6fe038f7dfbd03bd9d0745b8fb6f9f9dad Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Wed, 14 May 2025 18:16:03 +0000 Subject: [PATCH] mb/google/bluey: Select MISSING_BOARD_RESET due to lack of Chrome EC The Bluey board configuration (`BOARD_GOOGLE_BLUEY`) now selects `MISSING_BOARD_RESET`. This change is necessary because Bluey does not have a Chrome EC. Without a Chrome EC, a board-specific `do_board_reset()` implementation, which often handles system shutdown or reset sequences by interacting with an EC, is not feasible for Bluey. As a result of selecting `MISSING_BOARD_RESET`: - Bluey's `reset.c` is no longer compiled. - If a board reset is triggered, the system will use the stub `do_board_reset()` provided when `CONFIG_MISSING_BOARD_RESET` is enabled. This aligns Bluey's configuration with its hardware capabilities regarding system reset. BUG=b:404985109 TEST=Able to build google/bluey. Change-Id: I2f770ce9e96544b7e1891a3d8ec84a1313210891 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/87677 Reviewed-by: Kapil Porwal Tested-by: build bot (Jenkins) --- src/mainboard/google/bluey/Kconfig | 1 + src/mainboard/google/bluey/Makefile.mk | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/mainboard/google/bluey/Kconfig b/src/mainboard/google/bluey/Kconfig index 059708fbd0..eb1499548b 100644 --- a/src/mainboard/google/bluey/Kconfig +++ b/src/mainboard/google/bluey/Kconfig @@ -23,6 +23,7 @@ config BOARD_GOOGLE_BASEBOARD_BLUEY config BOARD_GOOGLE_BLUEY select BOARD_GOOGLE_BASEBOARD_BLUEY select MAINBOARD_HAS_FINGERPRINT_VIA_USB + select MISSING_BOARD_RESET if BOARD_GOOGLE_BLUEY_COMMON diff --git a/src/mainboard/google/bluey/Makefile.mk b/src/mainboard/google/bluey/Makefile.mk index 553634c29c..6018c9152a 100644 --- a/src/mainboard/google/bluey/Makefile.mk +++ b/src/mainboard/google/bluey/Makefile.mk @@ -2,7 +2,9 @@ all-y += boardid.c all-y += chromeos.c +ifneq ($(CONFIG_MISSING_BOARD_RESET),y) all-y += reset.c +endif bootblock-y += bootblock.c