From 1399dd808658bd33f3ebae891a37409fd0eb7f0b Mon Sep 17 00:00:00 2001 From: Shuo Liu Date: Fri, 15 Nov 2024 19:52:55 +0800 Subject: [PATCH] soc/intel/xeon_sp: Skip not pre-routed devices in _PRT reporting PCI devices not pre-routed will have their interrupt line left as 0. Skip these devices in _PRT reporting. TESTED=Build and boot on intel/avenuecity CRB Change-Id: I3d51b75eb0fd1c4ca877f6ac884de2742e7f9630 Signed-off-by: Shuo Liu Reviewed-on: https://review.coreboot.org/c/coreboot/+/85152 Reviewed-by: Lean Sheng Tan Reviewed-by: Tested-by: build bot (Jenkins) --- src/soc/intel/xeon_sp/acpi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/soc/intel/xeon_sp/acpi.c b/src/soc/intel/xeon_sp/acpi.c index 916e2df646..0a4587c21f 100644 --- a/src/soc/intel/xeon_sp/acpi.c +++ b/src/soc/intel/xeon_sp/acpi.c @@ -225,6 +225,8 @@ void acpigen_write_PRT_pre_routed(const struct device *br) uint8_t int_pin = pci_read_config8(dev, PCI_INTERRUPT_PIN); if ((int_pin > PCI_INT_MAX) || (int_pin < PCI_INT_A)) continue; + if (!int_line) + continue; acpigen_write_PRT_GSI_entry(dev_num, int_pin - PCI_INT_A, int_line);