erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/fatcat/var/fatcat: Modify interrupt GPIO for LPSS I2C touchpad

Browse source 
Change the interrupt GPIO for LPSS I2C based touchpad from GPP_F18
to GPP_A13 to match the current fatcat configuration.

BUG=b:376019577
TEST=Able to verify the touchpad functionality using 'THAT' touchpad
module.

Change-Id: I37a9d3aae67883f9eb4f47d76b4f48ac6ebb6d16
Signed-off-by: Pranava Y N <pranavayn@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85754
Reviewed-by: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
This commit is contained in:
Pranava Y N 2024-12-24 15:23:29 +05:30 • committed by Subrata Banik
commit 13316c644b
3 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/mainboard/google/fatcat/variants/fatcat/fw_config.c
View file

@ -439,8 +439,8 @@ static const struct pad_config touchpad_lpss_i2c_enable_pads[] = {
PAD_CFG_NF(GPP_F12, NONE, DEEP, NF8),
/* GPP_F13: THC_I2C1_SDA_TCH_PAD */
PAD_CFG_NF(GPP_F13, NONE, DEEP, NF8),
/* GPP_F18: TCH_PAD_INT_N */
PAD_CFG_GPI_APIC(GPP_F18, NONE, PLTRST, EDGE_SINGLE, INVERT),
/* GPP_A13: TCH_PAD_INT_N */
PAD_CFG_GPI_IRQ_WAKE(GPP_A13, NONE, PWROK, LEVEL, INVERT),
};
static const struct pad_config touchpad_i2c_disable_pads[] = {
@ -448,8 +448,8 @@ static const struct pad_config touchpad_i2c_disable_pads[] = {
PAD_NC(GPP_F12, NONE),
/* GPP_F13: THC_I2C1_SDA_TCH_PAD */
PAD_NC(GPP_F13, NONE),
/* GPP_F18: TCH_PAD_INT_N */
PAD_NC(GPP_F18, NONE),
/* GPP_A13: TCH_PAD_INT_N */
PAD_NC(GPP_A13, NONE),
};
static const struct pad_config ish_disable_pads[] = {

2
src/mainboard/google/fatcat/variants/fatcat/gpio.c
View file

@ -36,8 +36,6 @@ static const struct pad_config gpio_table[] = {
PAD_CFG_GPO(GPP_A11, 1, PLTRST),
/* GPP_A12: WIFI_WAKE_N */
PAD_CFG_GPI_SCI_LOW(GPP_A12, NONE, DEEP, LEVEL),
/* GPP_A13: Not used */
PAD_NC(GPP_A13, NONE),
/* GPP_A15: GPP_A15_DNX_FORCE_RELOAD */
PAD_CFG_NF(GPP_A15, NONE, DEEP, NF1),
/* GPP_A16: BT_RF_KILL_N */

2
src/mainboard/google/fatcat/variants/fatcat/overridetree.cb
View file

@ -756,7 +756,7 @@ chip soc/intel/pantherlake
chip drivers/i2c/hid
register "generic.hid" = ""HFW68H""
register "generic.desc" = ""Hynitron TOUCHPAD""
register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_F18_IRQ)"
register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_A13_IRQ)"
register "generic.uid" = "5"
register "generic.detect" = "1"
register "hid_desc_reg_offset" = "0x20"