From 124a7650e27fca817fd6a71677ca82813dcb45ca Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Sun, 14 Aug 2016 21:59:03 -0700 Subject: [PATCH] UPSTREAM: intel/quark: Fix assert check Having an assignment in assert does not make sense. This seems like it was intended to check if chip is always same as segments->chip. BUG=None BRANCH=None TEST=None Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/16219 Reviewed-by: Paul Menzel Reviewed-by: Aaron Durbin Reviewed-by: Lee Leahy Change-Id: I297d9e76a0404a1f510d43f8b9c39e96b557689f Reviewed-on: https://chromium-review.googlesource.com/370709 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Aaron Durbin --- src/soc/intel/quark/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/quark/i2c.c b/src/soc/intel/quark/i2c.c index 6465b66040..6b1f6dd46c 100644 --- a/src/soc/intel/quark/i2c.c +++ b/src/soc/intel/quark/i2c.c @@ -101,7 +101,7 @@ int platform_i2c_transfer(unsigned bus, struct i2c_seg *segments, int count) length = segments->len; ASSERT (buffer != NULL); ASSERT (length >= 1); - ASSERT (segments->chip = chip); + ASSERT (segments->chip == chip); if (segments->read) { /* Place read commands into the FIFO */