From 1222c704b582fa3283e2b36979d1862298fe85de Mon Sep 17 00:00:00 2001 From: Tongtong Pan Date: Fri, 27 Jun 2025 16:45:31 +0800 Subject: [PATCH] mb/google/fatcat/var/felino: Add pull high setting on GPP_V12 and NC_LOCK GPP_F09 To ensure that poweroff is normal and DUT can boot to S0 when press power button or lid open in S5 state, the WAKE pin GPP_V12 needs to be pulled high on soc side and GPP_F09 needs to be configured as NC_LOCK. BUG=413283383 TEST=emege-fatcat coreboot and poweroff and s5 boot functions are normal Change-Id: Iea8e44aa263dda7e447be1c9e53ffabf93c95a80 Signed-off-by: Tongtong Pan Reviewed-on: https://review.coreboot.org/c/coreboot/+/88211 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) --- src/mainboard/google/fatcat/variants/felino/gpio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mainboard/google/fatcat/variants/felino/gpio.c b/src/mainboard/google/fatcat/variants/felino/gpio.c index 87f4edddc8..8b05f1dfc8 100644 --- a/src/mainboard/google/fatcat/variants/felino/gpio.c +++ b/src/mainboard/google/fatcat/variants/felino/gpio.c @@ -266,8 +266,8 @@ static const struct pad_config gpio_table[] = { PAD_NC(GPP_F07, NONE), /* GPP_F08: NC */ PAD_NC(GPP_F08, NONE), - /* GPP_F09: SX_EXIT_HOLDOFF# */ - PAD_CFG_NF(GPP_F09, NONE, DEEP, NF2), + /* GPP_F09: NC */ + PAD_NC_LOCK(GPP_F09, NONE, LOCK_CONFIG), /* GPP_F10: HW_ID7 */ PAD_CFG_GPI(GPP_F10, NONE, PLTRST), /* GPP_F11: TC_RETIMER_FORCE_PWR */ @@ -380,7 +380,7 @@ static const struct pad_config gpio_table[] = { /* GPP_V11: SLP_LAN_N */ PAD_CFG_NF(GPP_V11, NONE, DEEP, NF1), /* GPP_V12: WAKE# */ - PAD_CFG_NF(GPP_V12, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_V12, UP_1K, DEEP, NF1), /* GPP_V13: GPP_V13_CATERR_N */ PAD_CFG_NF(GPP_V13, NONE, DEEP, NF1), /* GPP_V14: GPP_V14_FORCEPR_N */