From 10f8aa8b8a990126e66a1bb9b358baa9fe590d79 Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Thu, 8 Aug 2013 16:28:41 -0700 Subject: [PATCH] Add a specific post code for S3 resume failures If the firwmare is flashed and the MRC cache is blown away then it is not possible to resume. Right now this can be inferred from the event log but it can be made very clear by adding a unique post code for this event. BUG=none BRANCH=falco TEST=manual: 1) boot falco 2) flash firmware 3) suspend and then resume 4) check for post code 0xef in log 0 | 2013-08-08 16:27:47 | Log area cleared | 4096 1 | 2013-08-08 16:27:47 | ACPI Enter | S3 2 | 2013-08-08 16:27:55 | System boot | 48 3 | 2013-08-08 16:27:55 | Last post code in previous boot | 0xef | Resume Failure 4 | 2013-08-08 16:27:55 | System Reset 5 | 2013-08-08 16:27:55 | ACPI Wake | S5 Change-Id: I7602d9eef85d3b764781990249ae32b84fe84134 Signed-off-by: Duncan Laurie Reviewed-on: https://gerrit.chromium.org/gerrit/65259 Reviewed-by: Aaron Durbin --- src/include/console/post_codes.h | 8 ++++++++ src/northbridge/intel/haswell/raminit.c | 4 +++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/include/console/post_codes.h b/src/include/console/post_codes.h index 6e9aeb9daa..a9579508ce 100644 --- a/src/include/console/post_codes.h +++ b/src/include/console/post_codes.h @@ -228,6 +228,14 @@ */ #define POST_DEAD_CODE 0xee +/** + * \brief Resume from suspend failed + * + * This post code is sent when the firmware is expected to resume it is + * unable to do so. + */ +#define POST_RESUME_FAILURE 0xef + /** * \brief Final code before OS resumes * diff --git a/src/northbridge/intel/haswell/raminit.c b/src/northbridge/intel/haswell/raminit.c index c1095a7eb7..7263784d00 100644 --- a/src/northbridge/intel/haswell/raminit.c +++ b/src/northbridge/intel/haswell/raminit.c @@ -156,7 +156,9 @@ void sdram_initialize(struct pei_data *pei_data) /* If MRC data is not found we cannot continue S3 resume. */ if (pei_data->boot_mode == 2 && !pei_data->mrc_input) { - printk(BIOS_DEBUG, "Giving up in sdram_initialize: No MRC data\n"); + post_code(POST_RESUME_FAILURE); + printk(BIOS_DEBUG, "Giving up in sdram_initialize: " + "No MRC data\n"); outb(0x6, 0xcf9); while(1) { hlt();