From 103d86e68cd164bea39aa1edc8668d80358edbde Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Tue, 9 Aug 2016 13:23:02 -0700 Subject: [PATCH] Revert "gru: Show the current time on start-up" This reverts commit d0361193e0ec135e21f0611d7fa6e5c02f2b2bfc. google_chromeec_init() is a weird function that can lead to confusing behavior. I'm not sure how it's meant to work on the boards that use it, but it causes problems on Kevin and other non-x86 boards have never used it either. It doesn't really do anything anyway (the EC works fine without an initial HELLO), so at best it's just a waste of time... let's take it back out. There's also no need to display the current time on every boot... other boards don't do that and the eventlog already fills the same purpose. Cut it out to avoid one extra host command overhead. BRANCH=None BUG=chrome-os-partner:55995 TEST=Recovery reasons now get correctly propagated across the EC reboot. Change-Id: I58fd5e6094e1c8cb6368e7a4569ab9231375fbc9 Signed-off-by: Julius Werner Reviewed-on: https://chromium-review.googlesource.com/367351 Reviewed-by: Simon Glass Reviewed-by: Shelley Chen --- src/mainboard/google/gru/mainboard.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/mainboard/google/gru/mainboard.c b/src/mainboard/google/gru/mainboard.c index ec42af2792..3038d29b19 100644 --- a/src/mainboard/google/gru/mainboard.c +++ b/src/mainboard/google/gru/mainboard.c @@ -18,10 +18,7 @@ #include #include #include -#include -#include #include -#include #include #include #include @@ -165,17 +162,6 @@ static void setup_usb(void) setup_usb_otg1(); } -static void setup_rtc(void) -{ - struct rtc_time time; - int ret; - - /* Show the current time to see that the EC RTC is working */ - google_chromeec_init(); - ret = rtc_get(&time); - rtc_display(&time); -} - static void mainboard_init(device_t dev) { configure_sdmmc(); @@ -185,7 +171,6 @@ static void mainboard_init(device_t dev) setup_usb(); register_reset_to_bl31(); register_poweroff_to_bl31(); - setup_rtc(); } static void enable_backlight_booster(void)