From 0f7c54d7d121397bd8f01ffe0ba18d4e086217d6 Mon Sep 17 00:00:00 2001 From: Tongtong Pan Date: Thu, 6 Nov 2025 11:54:11 +0800 Subject: [PATCH] mb/google/fatcat/var/felino: Disable card reader in coreboot To resolve the issue of probabilistic inability to enter s0ix, We need to 1.Add reset_gpio for SSD RTD3 configuration 2.Disable card reader in coreboot BUG=b:431653999 TEST=dut can successfully enter S0IX during stress test. Change-Id: I7f8b117f23ca5639a17f2bace634ee84fce08247 Signed-off-by: Tongtong Pan Reviewed-on: https://review.coreboot.org/c/coreboot/+/89929 Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik Reviewed-by: Pranava Y N --- src/mainboard/google/fatcat/variants/felino/gpio.c | 2 +- .../google/fatcat/variants/felino/overridetree.cb | 10 ---------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/src/mainboard/google/fatcat/variants/felino/gpio.c b/src/mainboard/google/fatcat/variants/felino/gpio.c index 45e2ad4670..b430004257 100644 --- a/src/mainboard/google/fatcat/variants/felino/gpio.c +++ b/src/mainboard/google/fatcat/variants/felino/gpio.c @@ -187,7 +187,7 @@ static const struct pad_config gpio_table[] = { /* GPP_D17: PCH_DMIC_DATA1 */ PAD_CFG_NF(GPP_D17, NONE, DEEP, NF3), /* GPP_D18: PCIE_CLKREQ_SD_N */ - PAD_CFG_NF(GPP_D18, NONE, DEEP, NF1), + PAD_NC(GPP_D18, NONE), /* GPP_D19: NC */ PAD_NC(GPP_D19, NONE), /* GPP_D20: NC */ diff --git a/src/mainboard/google/fatcat/variants/felino/overridetree.cb b/src/mainboard/google/fatcat/variants/felino/overridetree.cb index 0d2b9c2da8..0be19ae39c 100644 --- a/src/mainboard/google/fatcat/variants/felino/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/felino/overridetree.cb @@ -204,16 +204,6 @@ device ref tbt_pcie_rp0 on end end end - device ref pcie_rp2 on - # Enable PCH PCIE x1 slot using CLK 6 - register "pcie_rp[PCIE_RP(2)]" = "{ - .clk_src = 6, - .clk_req = 6, - .flags = PCIE_RP_HOTPLUG | PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER, - .pcie_rp_aspm = ASPM_L1, - }" - end # SD Card - device ref pcie_rp4 on probe WIFI WIFI_PCIE_6 probe WIFI WIFI_PCIE_7