From 0f3589b3d7f166060f2d87b21f5d748abed741cd Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Thu, 6 Feb 2025 20:16:58 +0000 Subject: [PATCH] ec/starlabs/merlin: Add an option to disabled the lid switch Previously, the lid switch could be set to not wake the system. Add another option to ignore the switch entirely. Change-Id: I1dd666a44b332ffbbef4420799eeffd746fd1664 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/86305 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/starlabs/starbook/cfr.c | 7 ++++--- src/mainboard/starlabs/starfighter/cfr.c | 7 ++++--- src/mainboard/starlabs/starlite_adl/cfr.c | 7 ++++--- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/src/mainboard/starlabs/starbook/cfr.c b/src/mainboard/starlabs/starbook/cfr.c index 9b47f48345..bf0e4b0bcf 100644 --- a/src/mainboard/starlabs/starbook/cfr.c +++ b/src/mainboard/starlabs/starbook/cfr.c @@ -126,11 +126,12 @@ static const struct sm_object kbl_timeout = SM_DECLARE_ENUM({ static const struct sm_object lid_switch = SM_DECLARE_ENUM({ .opt_name = "lid_switch", .ui_name = "Lid Switch", - .ui_helptext = "Enable or disable the lid switch.", + .ui_helptext = "Configure what opening or closing the lid will do.", .default_value = 0, .values = (const struct sm_enum_value[]) { - { "Enabled", 0 }, - { "Disabled", 1 }, + { "Normal", 0 }, + { "Sleep Only", 1 }, + { "Disabled", 2 }, SM_ENUM_VALUE_END }, }); #endif diff --git a/src/mainboard/starlabs/starfighter/cfr.c b/src/mainboard/starlabs/starfighter/cfr.c index 7c8a123062..f310f86a64 100644 --- a/src/mainboard/starlabs/starfighter/cfr.c +++ b/src/mainboard/starlabs/starfighter/cfr.c @@ -108,11 +108,12 @@ static const struct sm_object kbl_timeout = SM_DECLARE_ENUM({ static const struct sm_object lid_switch = SM_DECLARE_ENUM({ .opt_name = "lid_switch", .ui_name = "Lid Switch", - .ui_helptext = "Enable or disable the lid switch.", + .ui_helptext = "Configure what opening or closing the lid will do.", .default_value = 0, .values = (const struct sm_enum_value[]) { - { "Enabled", 0 }, - { "Disabled", 1 }, + { "Normal", 0 }, + { "Sleep Only", 1 }, + { "Disabled", 2 }, SM_ENUM_VALUE_END }, }); #endif diff --git a/src/mainboard/starlabs/starlite_adl/cfr.c b/src/mainboard/starlabs/starlite_adl/cfr.c index 58a09a3d7c..a8e44fa11c 100644 --- a/src/mainboard/starlabs/starlite_adl/cfr.c +++ b/src/mainboard/starlabs/starlite_adl/cfr.c @@ -73,11 +73,12 @@ static const struct sm_object gna = SM_DECLARE_BOOL({ static const struct sm_object lid_switch = SM_DECLARE_ENUM({ .opt_name = "lid_switch", .ui_name = "Lid Switch", - .ui_helptext = "Enable or disable the lid switch.", + .ui_helptext = "Configure what opening or closing the lid will do.", .default_value = 0, .values = (const struct sm_enum_value[]) { - { "Enabled", 0 }, - { "Disabled", 1 }, + { "Normal", 0 }, + { "Sleep Only", 1 }, + { "Disabled", 2 }, SM_ENUM_VALUE_END }, }); #endif