From 0f1a18999c8dedf9f9ca2121a4bbb902ad5feee7 Mon Sep 17 00:00:00 2001 From: Jarried Lin Date: Mon, 17 Mar 2025 16:42:22 +0800 Subject: [PATCH] Revert "soc/mediatek/mt8196: Delay 0.5ms after enabling PMIF SPMI SW interface" This reverts commit c476c4d5b9f53f01c0f0b9673d3b9f0a29a6ae64. Reason for revert: Previously in CB:85799, we added a 0.5ms delay as a workaround to solve the boot hang issue of non-serial firmware. Now that the root cause has been identified and fixed in CB:86859, we can revert the workaround. Original change's description: CB:85799, commit c476c4d5b9f5 ("soc/mediatek/mt8196: Delay 0.5ms after enabling PMIF SPMI SW interface") BRANCH=rauru BUG=b:341054056 TEST=Build pass. Change-Id: I0abdcae95924c4d3197496c14d20502b08938d76 Signed-off-by: Jarried Lin Reviewed-on: https://review.coreboot.org/c/coreboot/+/86858 Tested-by: build bot (Jenkins) Reviewed-by: Yu-Ping Wu Reviewed-by: Yidi Lin --- src/soc/mediatek/mt8196/pmif_spmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/soc/mediatek/mt8196/pmif_spmi.c b/src/soc/mediatek/mt8196/pmif_spmi.c index cb78249662..665c64c7f6 100644 --- a/src/soc/mediatek/mt8196/pmif_spmi.c +++ b/src/soc/mediatek/mt8196/pmif_spmi.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only OR MIT */ #include -#include #include #include #include @@ -286,7 +285,6 @@ static void pmif_spmi_enable_swinf(struct pmif *arb) { write32(&arb->mtk_pmif->inf_en, PMIF_SPMI_SW_CHAN); write32(&arb->mtk_pmif->arb_en, PMIF_SPMI_SW_CHAN); - udelay(500); printk(BIOS_INFO, "%s done\n", __func__); }