From 0cdd4125bea28bdf150fd13067cc8abce0410869 Mon Sep 17 00:00:00 2001 From: Luca Lai Date: Mon, 2 Jun 2025 13:27:09 +0800 Subject: [PATCH] mb/trulo/var/pujjolo: Fix touchscreen function and boot up issue 1. Add serial_io_i2c_mode to fix can not boot up to OS issue. 2. Change level from low to high to fix parade touchscreen issue. BUG=b:395763555 BRANCH=none TEST=Build and boot to pujjolo. Verify functions work. Change-Id: Ic0a02daa39f4d1d0287115ecab12f45201704227 Signed-off-by: Luca Lai Reviewed-on: https://review.coreboot.org/c/coreboot/+/87909 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) --- .../google/brya/variants/pujjolo/overridetree.cb | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/brya/variants/pujjolo/overridetree.cb b/src/mainboard/google/brya/variants/pujjolo/overridetree.cb index 2f89d72859..7588a8bfb5 100644 --- a/src/mainboard/google/brya/variants/pujjolo/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjolo/overridetree.cb @@ -62,7 +62,8 @@ chip soc/intel/alderlake #| | required to set up a BAR | #| | for TPM communication | #| I2C1 | Touchscreen | - #| I2C2 | Sub-board(PSensor)/WCAM | + #| I2C2 | Psensor | + #| I2C4 | Mipi camera | #| I2C5 | Trackpad | #+-------------------+---------------------------+ register "common_soc_config" = "{ @@ -114,6 +115,15 @@ chip soc/intel/alderlake }, }" + register "serial_io_i2c_mode" = "{ + [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C1] = PchSerialIoPci, + [PchSerialIoIndexI2C2] = PchSerialIoPci, + [PchSerialIoIndexI2C3] = PchSerialIoDisabled, + [PchSerialIoIndexI2C4] = PchSerialIoPci, + [PchSerialIoIndexI2C5] = PchSerialIoPci, + }" + register "serial_io_gspi_mode" = "{ [PchSerialIoIndexGSPI0] = PchSerialIoPci, [PchSerialIoIndexGSPI1] = PchSerialIoPci, @@ -166,7 +176,7 @@ chip soc/intel/alderlake chip drivers/i2c/hid register "generic.hid" = ""PARA3408"" register "generic.desc" = ""Parade Touchscreen"" - register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E11_IRQ)" + register "generic.irq" = "ACPI_IRQ_LEVEL_HIGH(GPP_E11_IRQ)" register "generic.detect" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" register "generic.reset_delay_ms" = "20"