From 0c73e45493f871755e5a17fe5848b12dc4341e7c Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Thu, 9 Oct 2025 20:15:27 +0100 Subject: [PATCH] ec/starlabs/merlin: Add disabled option for lid switch There are three options for the LID switch: SWITCH_NORMAL 0x00 SWITCH_SLEEP_ONLY 0x01 SWITCH_DISABLED 0x02 Add these to coreboot to ensure they are set correctly. Change-Id: I159111438eabd4abeb654be75fd80f29bd835055 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/89502 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/ec/starlabs/merlin/ec.h | 5 +++-- src/ec/starlabs/merlin/ite.c | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/ec/starlabs/merlin/ec.h b/src/ec/starlabs/merlin/ec.h index 4b6b791771..b22b27917a 100644 --- a/src/ec/starlabs/merlin/ec.h +++ b/src/ec/starlabs/merlin/ec.h @@ -105,8 +105,9 @@ #define SPEED_0_2C 0x02 /* Lid Switch */ -#define SWITCH_ENABLED 0x00 -#define SWITCH_DISABLED 0x01 +#define SWITCH_NORMAL 0x00 +#define SWITCH_SLEEP_ONLY 0x01 +#define SWITCH_DISABLED 0x02 /* Power LED Brightness */ #define LED_NORMAL 0x00 diff --git a/src/ec/starlabs/merlin/ite.c b/src/ec/starlabs/merlin/ite.c index f034a0505a..f0566a9bd2 100644 --- a/src/ec/starlabs/merlin/ite.c +++ b/src/ec/starlabs/merlin/ite.c @@ -319,7 +319,8 @@ static void merlin_init(struct device *dev) * */ const uint8_t lid_switch[] = { - SWITCH_ENABLED, + SWITCH_NORMAL, + SWITCH_SLEEP_ONLY, SWITCH_DISABLED };