erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

device/azalia: Add enums for HDA verb and parameter IDs

Browse source 
This is a purely cosmetic change to make things slightly more easier to
read. We also only add the IDs which are actively used in the codebase.

TEST=Timeless build produces identical binaries

Change-Id: I4ec0a570020059c85768bab913dff1ba1977e9f9
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/88917
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
This commit is contained in:
Nicholas Sudsgaard 2025-08-21 08:42:47 +09:00 • committed by Matt DeVillier
commit 0a328282ec
2 changed files with 43 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/device/azalia_device.c
View file

@ -249,8 +249,7 @@ static bool codec_is_operative(u8 *base, const int addr)
return false;
}
const u32 reg32 = (addr << 28) | 0x000f0000;
write32(base + HDA_IC_REG, reg32);
write32(base + HDA_IC_REG, AZALIA_VERB_GET_VENDOR_ID(addr));
if (wait_for_valid(base) < 0) {
printk(BIOS_NOTICE, "azalia_audio: codec #%d doesn't respond\n", addr);