erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lib/rtc: Fix off-by-one error in February day count in leap year

Browse source 
The month argument passed to rtc_month_days is 0-based, not 1-based.
This results in the RTC being reverted to the build date constantly
on 29th February 2024.

Change-Id: If451e3e3471fef0d429e255cf297050a525ca1a2
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80790
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Michał Kopeć <michal.kopec@3mdeb.com>
(cherry picked from commit adf042f6c6)
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80823
This commit is contained in:
Michał Żygowski 2024-02-29 11:50:58 +01:00 • committed by Martin L Roth
commit 0a280ff747
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/lib/rtc.c
View file

@ -126,7 +126,7 @@ static int rtc_month_days(unsigned int month, unsigned int year)
{ {
int month_days[12] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 }; int month_days[12] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
return month_days[month] + (LEAP_YEAR(year) && month == 2); return month_days[month] + (LEAP_YEAR(year) && month == 1);
} }
int rtc_invalid(const struct rtc_time *tm) int rtc_invalid(const struct rtc_time *tm)