erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/alderlake: Prevent overlapping boot screens

Browse source 
Previously, `early_graphics_stop()` was skipped unconditionally if
`CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE)` was enabled. This led
to overlapping screens when CSE sync was not triggered in ramstage,
as both the eSOL message and the firmware splash screen would be
displayed.

This change refactors the condition for calling `early_graphics_stop()`
to ensure it is only skipped if a CSE firmware update is actually
required *and* `CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE)` is set.

This allows eSOL to display its message during CSE sync, but tears
down early graphics programming in other cases to prevent overlapping
screens.

Additionally, this change ensures that `early_graphics_stop()` is the
last function called by the romstage to guarantee proper cleanup.

BUG=b:362895813
TEST=Able to boot google/tivviks_ufs without overlapping screens.

Change-Id: Idc01bfc8963d65fcb0441300e7c9267eaaefefb9
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84144
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Amanda Hwang <amanda_hwang@compal.corp-partner.google.com>
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Dinesh Gehlot <digehlot@google.com>
This commit is contained in:
Subrata Banik 2024-08-30 18:08:20 +05:30
commit 09ea33cdd8
1 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/soc/intel/alderlake/romstage/romstage.c
View file

@ -215,16 +215,18 @@ void mainboard_romstage_entry(void)
if (!s3wake)
save_dimm_info();
if (CONFIG(ENABLE_EARLY_DMA_PROTECTION))
vtd_enable_dma_protection();
/* Keep eSOL active if CSE sync is pending at ramstage */
if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE) && is_cse_fw_update_required())
return;
/*
* Turn-off early graphics configuration with two purposes:
* - Clear any potentially still on-screen message
* - Allow PEIM graphics driver to smoothly execute in ramstage if
* RUN_FSP_GOP is selected
*/
if (!CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE))
/* Keep eSOL active if CSE sync in ramstage config is enabled */
early_graphics_stop();
if (CONFIG(ENABLE_EARLY_DMA_PROTECTION))
vtd_enable_dma_protection();
early_graphics_stop();
}