erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/octopus/variants/dood: fix disable_xhci_lfps_pm by sku

Browse source 
due to overridetree.cb set disable_xhci_lfps_pm = 0,
need correct condition expression to let function work.

BUG=b:155955302
BRANCH=octopus
TEST=build coreboot with DisableXhciLfpsPM being set to 1 and flash
     the image to the device. Run following command to check if
     bits[7:4] is set 0:
     >iotools mmio_read32 "XHCI MMIO BAR + 0x80A4"

Signed-off-by: Kenneth Chan <kenneth.chan@quanta.corp-partner.google.com>
Change-Id: Ia047c75611a35aafd15f2481bf64049e13d4a2ff
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42860
Reviewed-by: Marco Chen <marcochen@google.com>
Reviewed-by: Henry Sun <henrysun@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Kenneth Chan 2020-06-29 17:47:09 +08:00 • committed by Patrick Georgi
commit 094639c214
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/mainboard/google/octopus/variants/dood/variant.c
View file

@ -68,7 +68,7 @@ void variant_update_devtree(struct device *dev)
cfg = (struct soc_intel_apollolake_config *)dev->chip_info;
if (cfg != NULL && cfg->disable_xhci_lfps_pm) {
if (cfg != NULL && (cfg->disable_xhci_lfps_pm != 1)) {
switch (google_chromeec_get_board_sku()) {
case SKU_1_LTE:
case SKU_3_LTE_2CAM: